]> git.ipfire.org Git - thirdparty/git.git/commit - sha1-file.c
sha1_file: introduce a constant for max header length
authorbrian m. carlson <sandals@crustytoothpaste.net>
Mon, 12 Mar 2018 02:27:55 +0000 (02:27 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 14 Mar 2018 16:23:50 +0000 (09:23 -0700)
commit1af64f73a9113b189ce4cc3e422ec927e9b32084
treeb9c3f2ab8e8c30dc27389e05a25b2ed80a9a347d
parentb383a13cc0dbed752b69d7ad249bc857b9d3607b
sha1_file: introduce a constant for max header length

There were several instances of 32 sprinkled throughout this file, all
of which were used for allocating a buffer to store the header of an
object.  Introduce a constant, MAX_HEADER_LEN, for this purpose.

Note that this constant is slightly larger than required; the longest
possible header is 28 (7 for "commit", 1 for a space, 20 for a 63-bit
length in decimal, and 1 for the NUL).  However, the overallocation
should not cause any problems, so leave it as it is.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sha1_file.c