]> git.ipfire.org Git - thirdparty/git.git/commit - t/t6120-describe.sh
describe tests: don't rely on err.actual from "check_describe"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Mon, 12 Apr 2021 11:21:45 +0000 (13:21 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 11 May 2021 03:48:09 +0000 (12:48 +0900)
commit7f07c1cdb7f46d2b0ec4468a90da7a4d697d2978
tree169efe94b2695bb4b54e3513c2f51e0ba7c971da
parenta46a84829650fbe6077e5a33f4ac1c9d2041d1df
describe tests: don't rely on err.actual from "check_describe"

Convert the one test that relied on the "err.actual" file produced by
check_describe() to instead do its own check of "git describe"
output.

This means that the two tests won't have an inter-dependency (e.g. if
the earlier test is skipped).

An earlier version of this patch instead asserted that no other test
had any output on stderr. We're not doing that here out of fear that
"gc --auto" or another future change to "git describe" will cause it
to legitimately emit output on stderr unexpectedly[1].

I'd think that inverting the test added in 3291fe4072e (Add
git-describe test for "verify annotated tag names on output",
2008-03-03) to make checking that we don't have warnings the rule
rather than the exception would be the sort of thing the describe
tests should be catching, but for now let's leave it as it is.

1. http://lore.kernel.org/git/xmqqwnuqo8ze.fsf@gitster.c.googlers.com

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t6120-describe.sh