]> git.ipfire.org Git - thirdparty/git.git/commit - unpack-trees.h
tree-walk.c: break circular dependency with unpack-trees
authorJeff King <peff@peff.net>
Sat, 1 Feb 2020 11:39:22 +0000 (06:39 -0500)
committerJunio C Hamano <gitster@pobox.com>
Tue, 4 Feb 2020 18:32:15 +0000 (10:32 -0800)
commit5290d4513496d89f84570985a0e02e97dff477ff
tree0087ed94f0234309e2d4862c1d7e6e4e809a8890
parent8dd40c0472a8f51f4fba4b8fd28dc3e9421cd7d7
tree-walk.c: break circular dependency with unpack-trees

The unpack-trees API depends on the tree-walk API. But we've recently
introduced a dependency in tree-walk.c on MAX_UNPACK_TREES, which
doesn't otherwise care about unpack-trees at all.

Let's break that dependency by reversing the constants: we'll introduce
a new MAX_TRAVERSE_TREES which belongs to the tree-walk API. And then we
can define MAX_UNPACK_TREES in terms of that (since unpack-trees cannot
possibly work with more trees than it can traverse at once via
tree-walk).

The value for both will remain at 8. This is somewhat arbitrary and
probably more than is necessary, per ca885a4fe6 (read-tree() and
unpack_trees(): use consistent limit, 2008-03-13), but there's not
really any pressing need to reduce it.

Suggested-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
tree-walk.c
tree-walk.h
unpack-trees.h