]> git.ipfire.org Git - thirdparty/git.git/commit - upload-pack.c
run-command API users: use strvec_pushl(), not argv construction
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 25 Nov 2021 22:52:20 +0000 (23:52 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 26 Nov 2021 06:15:07 +0000 (22:15 -0800)
commit2b7098936c9e91d527aa53b8d4af0b25d7e912b4
treed0042309f280e1246533b9bd0bcc70d5ff6ebbbc
parent87ee87dd6bb633cd5171e244fb69cd4b66d294aa
run-command API users: use strvec_pushl(), not argv construction

Change a pattern of hardcoding an "argv" array size, populating it and
assigning to the "argv" member of "struct child_process" to instead
use "strvec_pushl()" to add data to the "args" member.

This implements the same behavior as before in fewer lines of code,
and moves us further towards being able to remove the "argv" member in
a subsequent commit.

Since we've entirely removed the "argv" variable(s) we can be sure
that no potential logic errors of the type discussed in a preceding
commit are being introduced here, i.e. ones where the local "argv" was
being modified after the assignment to "struct child_process"'s
"argv".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/add.c
builtin/fsck.c
builtin/help.c
builtin/merge.c
builtin/notes.c
builtin/receive-pack.c
builtin/replace.c
editor.c
sequencer.c
upload-pack.c