]> git.ipfire.org Git - thirdparty/git.git/commit - upload-pack.c
serve: mark unused parameters in virtual functions
authorJeff King <peff@peff.net>
Fri, 24 Feb 2023 06:38:23 +0000 (01:38 -0500)
committerJunio C Hamano <gitster@pobox.com>
Fri, 24 Feb 2023 17:13:29 +0000 (09:13 -0800)
commit74595cca21a41e4be6ca8d578d805b70b7653e98
tree466fae2f8270bd428a11290863b4bae97221f5de
parent4b4e75dd4f1dac0c25bded7466b0cc20c9649efb
serve: mark unused parameters in virtual functions

Each v2 "serve" action has a virtual function for advertising and
implementing the command. A few of these are so trivial that they don't
need to look at their parameters, especially the "repository" parameter.
We can mark them so that -Wunused-parameter doesn't complain.

Note that upload_pack_v2() probably _should_ be using its repository
pointer. But teaching the functions it calls to do so is non-trivial.
Even using it for something as simple as reading config is tricky, both
because it shares code with the v1 upload pack, and because the
git_protected_config() mechanism it uses does not have a repo-specific
interface. So we'll just annotate it for now, and cleaning it up can be
part of the larger work to drop references to the_repository.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
serve.c
upload-pack.c