]> git.ipfire.org Git - thirdparty/git.git/commit - usage.c
fmt_with_err: add a comment that truncation is OK
authorJeff King <peff@peff.net>
Sat, 19 May 2018 01:58:44 +0000 (18:58 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 21 May 2018 00:59:14 +0000 (09:59 +0900)
commitac4896f007a624c12feda866aeb4abe8a1394e39
treeab584b8548ba953ac1110170bc117479add3dbdd
parentbf4baf1fed7916ed10f2759a6f30a38990a83cae
fmt_with_err: add a comment that truncation is OK

Functions like die_errno() use fmt_with_err() to combine the
caller-provided format with the strerror() string. We use a
fixed stack buffer because we're already handling an error
and don't have any way to report another one. Our buffer
should generally be big enough to fit this, but if it's not,
truncation is our best option. Let's add a comment to that
effect, so that anybody auditing the code for truncation
bugs knows that this is fine.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
usage.c