]> git.ipfire.org Git - thirdparty/git.git/commit - write-or-die.c
Clean up write_in_full() users
authorLinus Torvalds <torvalds@osdl.org>
Fri, 12 Jan 2007 04:23:00 +0000 (20:23 -0800)
committerJunio C Hamano <junkio@cox.net>
Fri, 12 Jan 2007 05:02:58 +0000 (21:02 -0800)
commitd34cf19b8987ae0f0806e257edf877238d044747
tree62c54c75d209587d44efc0528bd04d7cd8a8f472
parent9bbaa6cc6848b68b8bef681c2a22b57bbec3e914
Clean up write_in_full() users

With the new-and-improved write_in_full() semantics, where a partial write
simply always returns a real error (and always sets 'errno' when that
happens, including for the disk full case), a lot of the callers of
write_in_full() were just unnecessarily complex.

In particular, there's no reason to ever check for a zero length or
return: if the length was zero, we'll return zero, otherwise, if a disk
full resulted in the actual write() system call returning zero the
write_in_full() logic would have correctly turned that into a negative
return value, with 'errno' set to ENOSPC.

I really wish every "write_in_full()" user would just check against "<0"
now, but this fixes the nasty and stupid ones.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
sha1_file.c
write_or_die.c