]> git.ipfire.org Git - thirdparty/git.git/commit
reftable/record: reuse refnames when decoding log records
authorPatrick Steinhardt <ps@pks.im>
Tue, 5 Mar 2024 12:11:07 +0000 (13:11 +0100)
committerJunio C Hamano <gitster@pobox.com>
Tue, 5 Mar 2024 17:10:06 +0000 (09:10 -0800)
commit193fcb3ff82184c3c7b7e3d0da9d0b7aaa648b91
tree3c72d19b3f0d9b0ed5a74a0925aaf86c7dbe6d98
parent01639ec148f3b5ecd4460a2a5720f987c0b6a247
reftable/record: reuse refnames when decoding log records

When decoding a log record we always reallocate their refname arrays.
This results in quite a lot of needless allocation churn.

Refactor the code to grow the array as required only. Like this, we
should usually only end up reallocating the array a small handful of
times when iterating over many refs. Before:

    HEAP SUMMARY:
        in use at exit: 13,473 bytes in 122 blocks
      total heap usage: 4,068,487 allocs, 4,068,365 frees, 332,011,793 bytes allocated

After:

    HEAP SUMMARY:
        in use at exit: 13,473 bytes in 122 blocks
      total heap usage: 3,068,488 allocs, 3,068,366 frees, 307,122,961 bytes allocated

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
reftable/record.c
reftable/reftable-record.h