]> git.ipfire.org Git - thirdparty/git.git/commit
url: do not read past end of buffer
authorMatthew DeVore <matvore@google.com>
Tue, 4 Jun 2019 17:57:04 +0000 (10:57 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 4 Jun 2019 21:48:06 +0000 (14:48 -0700)
commit3f6b8a6177f3197ddad82a6da2ff9b4704664f5d
treea70f26379a9a1b3abcb2c616620cce994c7450df
parentaeb582a98374c094361cba1bd756dc6307432c42
url: do not read past end of buffer

url_decode_internal could have been tricked into reading past the length
of the **query buffer if there are fewer than 2 characters after a % (in
a null-terminated string, % would have to be the last character).
Prevent this from happening by checking len before decoding the %
sequence.

Helped-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
url.c