]> git.ipfire.org Git - thirdparty/git.git/commit
format-patch: replace erroneous and condition
authorDenton Liu <liu.denton@gmail.com>
Tue, 15 Oct 2019 09:06:35 +0000 (02:06 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 16 Oct 2019 01:26:42 +0000 (10:26 +0900)
commit46273df7bfdd43e5f8a190d0a80a078ca55ce5ff
tree65038c10c03da9948c628f60b1df5b46b564f1ea
parent756fb0dedb72e8eec691d216198ccc23102d7072
format-patch: replace erroneous and condition

Commit 30984ed2e9 (format-patch: support deep threading, 2009-02-19),
introduced the following lines:

#define THREAD_SHALLOW 1

[...]

thread = git_config_bool(var, value) && THREAD_SHALLOW;

Since git_config_bool() returns a bool, the trailing `&& THREAD_SHALLOW`
is a no-op. Replace this errorneous and condition with a ternary
statement so that it is clear what the configured value is when a
boolean is given.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/log.c