]> git.ipfire.org Git - thirdparty/git.git/commit
list-objects-filter: treat NULL filter_options as "disabled"
authorJeff King <peff@peff.net>
Mon, 4 May 2020 23:12:27 +0000 (17:12 -0600)
committerJunio C Hamano <gitster@pobox.com>
Tue, 5 May 2020 04:57:58 +0000 (21:57 -0700)
commit5bf7f1eaa51b3f35161e1c9e4d8bc843330dea3c
tree4947c967130e1c5d322a2fb305fd684c1bd63ebb
parentb34789c0b0d3b137f0bb516b417bd8d75e0cb306
list-objects-filter: treat NULL filter_options as "disabled"

In most callers, we have an actual list_objects_filter_options struct,
and if no filtering is desired its "choice" element will be
LOFC_DISABLED. However, some code may have only a pointer to such a
struct which may be NULL (because _their_ callers didn't care about
filtering, either). Rather than forcing them to handle this explicitly
like:

  if (filter_options)
          traverse_commit_list_filtered(filter_options, revs,
                                show_commit, show_object,
show_data, NULL);
  else
          traverse_commit_list(revs, show_commit, show_object,
                             show_data);

let's just treat a NULL filter_options the same as LOFC_DISABLED. We
only need a small change, since that option struct is converted into a
real filter only in the "init" function.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
list-objects-filter.c