]> git.ipfire.org Git - thirdparty/git.git/commit
t: factor out FUNNYNAMES as shared lazy prereq
authorWilliam Chargin <wchargin@gmail.com>
Mon, 6 Aug 2018 18:35:08 +0000 (11:35 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 6 Aug 2018 20:35:15 +0000 (13:35 -0700)
commit6ec633059ad0b17850ad18c7325678d6c845b74c
tree64f5d0afb47d1427a3b3aac6474f5bfbb34f5337
parent53f9a3e157dbbc901a02ac2c73346d375e24978c
t: factor out FUNNYNAMES as shared lazy prereq

A fair number of tests need to check that the filesystem supports file
names including "funny" characters, like newline, tab, and double-quote.
Jonathan Nieder suggested that this be extracted into a lazy prereq in
the top-level `test-lib.sh`. This patch effects that change.

The FUNNYNAMES prereq now uniformly requires support for newlines, tabs,
and double-quotes in filenames. This very slightly decreases the power
of some tests, which might have run previously on a system that supports
(e.g.) newlines and tabs but not double-quotes, but now will not. This
seems to me like an acceptable tradeoff for consistency.

One test (`t/t9902-completion.sh`) defined FUNNYNAMES to further require
the separators \034 through \037, the test for which was implemented
using the Bash-specific $'\034' syntax. I've elected to leave this one
as is, renaming it to FUNNIERNAMES.

After this patch, `git grep 'test_\(set\|lazy\)_prereq.*FUNNYNAMES'` has
only one result.

Signed-off-by: William Chargin <wchargin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t3600-rm.sh
t/t4135-apply-weird-filenames.sh
t/t9902-completion.sh
t/t9903-bash-prompt.sh
t/test-lib.sh