]> git.ipfire.org Git - thirdparty/git.git/commit
t: teach lint that RHS of 'local VAR=VAL' needs to be quoted
authorJunio C Hamano <gitster@pobox.com>
Sat, 6 Apr 2024 00:09:02 +0000 (17:09 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sat, 6 Apr 2024 05:50:11 +0000 (22:50 -0700)
commit8bfe4861913843b6aac8656aabfd43ac405362e8
tree08b8374f4bc0dbe11aa97e2d5348396387dca3d8
parente97f4a6d94103c43a08c864c6ab63e6086812998
t: teach lint that RHS of 'local VAR=VAL' needs to be quoted

Teach t/check-non-portable-shell.pl that right hand side of the
assignment done with "local VAR=VAL" need to be quoted.  We
deliberately target only VAL that begins with $ so that we can catch

 - $variable_reference and positional parameter reference like $4
 - $(command substitution)
 - ${variable_reference-with_magic}

while excluding

 - $'\n' that is a bash-ism freely usable in t990[23]
 - $(( arithmetic )) whose result should be $IFS safe.
 - $? that also is $IFS safe

Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/check-non-portable-shell.pl