]> git.ipfire.org Git - thirdparty/git.git/commit
blame: remove unnecessary use of get_commit_info()
authorRafael Silva <rafaeloliveira.cs@gmail.com>
Wed, 17 Feb 2021 14:54:43 +0000 (15:54 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 17 Feb 2021 19:04:17 +0000 (11:04 -0800)
commit8e16effe97f9963a77aa977a38318d8a50d96312
tree4f46511642aaa737081e70d9574e251379e248ad
parent59ec22464f6c2b170b05f287e00740ea2288fe5c
blame: remove unnecessary use of get_commit_info()

When `git blame --color-by-age`, the determine_line_heat() is called to
select how to color the output based on the commit's author date.  It
uses the get_commit_info() to parse the information into a `commit_info`
structure, however, this is actually unnecessary because the
determine_line_heat() caller also does the same.

Instead, let's change the determine_line_heat() to take a `commit_info`
structure and remove the internal call to get_commit_info() thus
cleaning up and optimizing the code path.

Enabling Git's trace2 API in order to record the execution time for
every call to determine_line_heat() function:

   + trace2_region_enter("blame", "determine_line_heat", the_repository);
     determine_line_heat(ent, &default_color);
   + trace2_region_enter("blame", "determine_line_heat", the_repository);

Then, running `git blame` for "kernel/fork.c" in linux.git and summing
all the execution time for every call (around 1.3k calls) resulted in
2.6x faster execution (best out 3):

   git built from 328c109303 (The eighth batch, 2021-02-12) = 42ms
   git built from 328c109303 + this change                  = 16ms

Signed-off-by: Rafael Silva <rafaeloliveira.cs@gmail.com>
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/blame.c