]> git.ipfire.org Git - thirdparty/git.git/commit
rev-parse: put all options under the "-" check
authorJeff King <peff@peff.net>
Tue, 10 Nov 2020 21:38:03 +0000 (16:38 -0500)
committerJunio C Hamano <gitster@pobox.com>
Tue, 10 Nov 2020 21:46:27 +0000 (13:46 -0800)
commit9033addfa6a910325fbe9619dc623c17e989261c
tree8ad3e9b515451c08b13aa4b41719cd6cf4d130fb
parente05e2ae8fe6e5d83254c27664c66bc47b270b6d2
rev-parse: put all options under the "-" check

The option-parsing loop of rev-parse checks whether the first character
of an arg is "-". If so, then it enters a series of conditionals
checking for individual options. But some options are inexplicably
outside of that outer conditional.

This doesn't produce the wrong behavior; the conditional is actually
redundant with the individual option checks, and it's really only its
fallback "continue" that we care about. But we should at least be
consistent.

One obvious alternative is that we could get rid of the conditional
entirely. But we'll be using the extra block it provides in the next
patch.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/rev-parse.c