]> git.ipfire.org Git - thirdparty/git.git/commit
reflog tests: assert lack of early exit with expiry="never"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 28 Mar 2019 16:14:33 +0000 (17:14 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 1 Apr 2019 03:51:51 +0000 (12:51 +0900)
commit978f4307638917127704716b754aed0953452bf4
tree3d1bbd80b5b66f4cc5c0023e247b2890475b63f1
parentfe66776db0b841d4d4cf64f078e1ffd82193442a
reflog tests: assert lack of early exit with expiry="never"

When gc.reflogExpire and gc.reflogExpireUnreachable are set to "never"
and --stale-fix isn't in effect we *could* exit early without
pointlessly looping over all the reflogs.

However, as an earlier change to add a test for the "points nowhere"
warning shows even in such a mode we might want to print out a
warning.

So while it's conceivable to implement this, I don't think it's worth
it. It's going to be too easy to inadvertently add some flag that'll
make the expiry happen anyway, and even with "never" we'd like to see
all the lines we're going to keep.

So let's assert that we're going to loop over all the references even
when this configuration is in effect.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t1410-reflog.sh