]> git.ipfire.org Git - thirdparty/git.git/commit
refs: fix some exclude patterns being ignored
authorRafael Ascensão <rafa.almas@gmail.com>
Mon, 12 Nov 2018 13:25:44 +0000 (13:25 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 13 Nov 2018 05:41:22 +0000 (14:41 +0900)
commit9ab9b5df0ee2a49e0c1354a667e1e00db903f516
tree12d807f4027241a66ecd1eba1bfb5b18affeb005
parent9d55dca262e8657b87dbd4c5b3494e1ecb7a0dbd
refs: fix some exclude patterns being ignored

`--exclude` from rev-list and rev-parse fails to exclude references if
the next `--branches`, `--tags` or `--remotes` use the optional
inclusive glob because those options are implemented as particular cases
of `--glob=`, which itself requires that exclude patterns begin with
'refs/'.

But it makes sense for `--branches=glob` and friends to be aware that
exclusions patterns for them shouldn't be 'refs/<type>/' prefixed, the
same way exclude patterns for `--branches` and friends (without the
optional glob) already are.

Let's record in 'refs.c:struct ref_filter' which context the exclude
pattern is tied to, so refs.c:filter_refs() can decide if it should
ignore the prefix when trying to match.

Signed-off-by: Rafael Ascensão <rafa.almas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs.c
t/t6018-rev-list-glob.sh