]> git.ipfire.org Git - thirdparty/git.git/commit
vcs-svn: a void function shouldn't try to return something
authorMichael Witten <mfwitten@gmail.com>
Tue, 29 Mar 2011 17:31:30 +0000 (17:31 +0000)
committerJonathan Nieder <jrnieder@gmail.com>
Tue, 29 Mar 2011 19:47:02 +0000 (14:47 -0500)
commit9e113988d3d95f1595e2c33f704defeb2cbcc5d6
treeaae49d07c0f1c1bb0fcd94d81606837b7785af65
parent4c502d68666acba7a83379c7abd971aafee91cf8
vcs-svn: a void function shouldn't try to return something

As v1.7.4-rc0~184 (2010-10-04) and C99 ยง6.8.6.4.1 remind us, standard
C does not permit returning an expression of type void, even for a
tail call.

Noticed with gcc -pedantic:

 vcs-svn/svndump.c: In function 'handle_node':
 vcs-svn/svndump.c:213:3: warning: ISO C forbids 'return' with expression,
  in function returning void [-pedantic]

[jn: with simplified log message]

Signed-off-by: Michael Witten <mfwitten@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
vcs-svn/svndump.c