]> git.ipfire.org Git - thirdparty/git.git/commit
credential-store: ignore bogus lines from store file
authorCarlo Marcelo Arenas Belón <carenas@gmail.com>
Sat, 2 May 2020 22:34:47 +0000 (15:34 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sun, 3 May 2020 01:10:38 +0000 (18:10 -0700)
commitc03859a66525c6bdc5cd3c02b31f06cfdd80b595
tree350a3dc97b28e87a7f34bc961997193263abf6b8
parent20b4964fdf43491494122fbd297b2da7d66663b2
credential-store: ignore bogus lines from store file

With the added checks for invalid URLs in credentials, any locally
modified store files which might have empty lines or even comments
were reported[1] failing to parse as valid credentials.

Instead of doing a hard check for credentials, do a soft one and
therefore avoid the reported fatal error.

While at it add tests for all known corruptions that are currently
ignored to keep track of them and avoid the risk of regressions.

[1] https://stackoverflow.com/a/61420852/5005936

Reported-by: Dirk <dirk@ed4u.de>
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Based-on-patch-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
credential-store.c
t/t0302-credential-store.sh