]> git.ipfire.org Git - thirdparty/git.git/commit
t: warn against adding non-httpd-specific tests after sourcing 'lib-httpd'
authorSZEDER Gábor <szeder.dev@gmail.com>
Thu, 1 Aug 2019 15:53:09 +0000 (17:53 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 2 Aug 2019 16:35:57 +0000 (09:35 -0700)
commitdecfe05bb668771fb25a23021b2b33bc7649cd32
tree1222688cf5fab1dce45e266169b9120816c75e5b
parent7f005b0f483a507d3c7b353f4753ac3fece88bc0
t: warn against adding non-httpd-specific tests after sourcing 'lib-httpd'

We have a couple of test scripts that are not completely
httpd-specific, but do run a few httpd-specific tests at the end.
These test scripts source 'lib-httpd.sh' somewhere mid-script, which
then skips all the rest of the test script if the dependencies for
running httpd tests are not fulfilled.

As the previous two patches in this series show, already on two
occasions non-httpd-specific tests were appended at the end of such
test scripts, and, consequently, they were skipped as well when httpd
tests couldn't be run.

Add a comment at the end of these test scripts to warn against adding
non-httpd-specific tests at the end, in the hope that they will help
prevent similar issues in the future.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t0410-partial-clone.sh
t/t5500-fetch-pack.sh
t/t5537-fetch-shallow.sh
t/t5545-push-options.sh
t/t5601-clone.sh
t/t5616-partial-clone.sh
t/t5700-protocol-v1.sh
t/t5702-protocol-v2.sh