]> git.ipfire.org Git - thirdparty/git.git/commit
t5318: use 'test_cmp_bin' to compare commit-graph files
authorSZEDER Gábor <szeder.dev@gmail.com>
Mon, 13 Aug 2018 11:52:43 +0000 (13:52 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 13 Aug 2018 19:07:29 +0000 (12:07 -0700)
commiteb7cc5bc809665175b436982682de3f87dc9d6a4
treeeca21354f3be1dc3e6010facf77b9e97856db57a
parentb18ef13a3fc5ed6e77980f67a7f3ca89050c1715
t5318: use 'test_cmp_bin' to compare commit-graph files

The commit-graph files are binary files, so they should not be
compared with 'test_cmp', because that might cause issues like
crashing[1] or infinite loop[2] on Windows, where 'test_cmp' is a
shell function to deal with random LF-CRLF conversions[3].

Use 'test_cmp_bin' instead.

1 - b93e6e3663 (t5000, t5003: do not use test_cmp to compare binary
    files, 2014-06-04)
2 - f9f3851b4d (t9300: use test_cmp_bin instead of test_cmp to compare
    binary files, 2014-09-12)
3 - 4d715ac05c (Windows: a test_cmp that is agnostic to random LF <>
    CRLF conversions, 2013-10-26)

Reviewed-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5318-commit-graph.sh