]> git.ipfire.org Git - thirdparty/git.git/commit
send-email: restore --in-reply-to superseding behavior
authorRafael Aquini <aquini@redhat.com>
Mon, 29 Jun 2020 14:11:04 +0000 (10:11 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 1 Jul 2020 23:12:21 +0000 (16:12 -0700)
commitf9f60d70663a89ff06fd38c806e47fc51f29ff72
treef59bdbd0ad3a39b8f8dbb0be039a82b45619c951
parentaf6b65d45ef179ed52087e80cb089f6b2349f4ec
send-email: restore --in-reply-to superseding behavior

git send-email --in-reply-to= fails to override In-Reply-To email headers,
if they're present in the output of format-patch, even when explicitly
told to do so by the option --no-thread, which breaks the contract of the
command line switch option, per its man page.

"
   --in-reply-to=<identifier>
       Make the first mail (or all the mails with --no-thread) appear as
       a reply to the given Message-Id, which avoids breaking threads to
       provide a new patch series.
"

This patch fixes the aformentioned issue, by bringing --in-reply-to's old
overriding behavior back.

The test was donated by Carlo Marcelo Arenas Belón.

Signed-off-by: Rafael Aquini <aquini@redhat.com>
Helped-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-send-email.perl
t/t9001-send-email.sh