]> git.ipfire.org Git - thirdparty/git.git/commitdiff
send-email: sanitize_address use $foo, not "$foo"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 30 Sep 2010 13:43:02 +0000 (13:43 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 30 Sep 2010 19:20:33 +0000 (12:20 -0700)
There's no reason to explicitly stringify a variable in Perl unless
it's an overloaded object and you want to call overload::StrVal,
otherwise it's just creating a new scalar redundantly.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-send-email.perl

index 1218bbe729ad73ebd51bf98b7e46a14c2dcccde8..1bf090a881831e86148aee857e307f762a2f8924 100755 (executable)
@@ -864,7 +864,7 @@ sub sanitize_address {
        my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/);
 
        if (not $recipient_name) {
-               return "$recipient";
+               return $recipient;
        }
 
        # if recipient_name is already quoted, do nothing