From: Jonathan Nieder Date: Fri, 8 Oct 2010 16:46:59 +0000 (-0500) Subject: Documentation: No argument of ALLOC_GROW should have side-effects X-Git-Tag: v1.7.3.2~16 X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fgit.git;a=commitdiff_plain;h=01f6fd4b4e59bc131941d917138cdd2cc6662382 Documentation: No argument of ALLOC_GROW should have side-effects The explanatory comment before the definition of ALLOC_GROW carefully lists arguments that will be used more than once and thus cannot have side-effects; a lazy reader might conclude that the arguments not listed are used only once and side effects safe. Correct it to list all three arguments, avoiding this confusion. Signed-off-by: Jonathan Nieder Signed-off-by: Junio C Hamano --- diff --git a/cache.h b/cache.h index 3d5ed51989..33decd942d 100644 --- a/cache.h +++ b/cache.h @@ -445,7 +445,7 @@ extern int init_db(const char *template_dir, unsigned int flags); * at least 'nr' entries; the number of entries currently allocated * is 'alloc', using the standard growing factor alloc_nr() macro. * - * DO NOT USE any expression with side-effect for 'x' or 'alloc'. + * DO NOT USE any expression with side-effect for 'x', 'nr', or 'alloc'. */ #define ALLOC_GROW(x, nr, alloc) \ do { \