From 32b5fe7f0e2cb798954b3e01b990bc140706e191 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Mon, 4 May 2020 12:07:09 -0400 Subject: [PATCH] CodingGuidelines: drop arithmetic expansion advice to use "$x" MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The advice to use "$x" rather than "x" in arithmetric expansion was working around a dash bug fixed in 0.5.4. Even Debian oldstable has 0.5.8 these days. And in the meantime, we've added almost two dozen instances of the "x" form which you can find with: git grep '$(([a-z]' and nobody seems to have complained. Let's declare this workaround obsolete and simplify our style guide. Helped-by: Danh Doan Signed-off-by: Jeff King Reviewed-by: Carlo Marcelo Arenas Belón Signed-off-by: Junio C Hamano --- Documentation/CodingGuidelines | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index ed4e443a3c..6fc85caffa 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -97,10 +97,6 @@ For shell scripts specifically (not exhaustive): - We use Arithmetic Expansion $(( ... )). - - Inside Arithmetic Expansion, spell shell variables with $ in front - of them, as some shells do not grok $((x)) while accepting $(($x)) - just fine (e.g. dash older than 0.5.4). - - We do not use Process Substitution <(list) or >(list). - Do not write control structures on a single line with semicolon. -- 2.39.2