]> git.ipfire.org Git - thirdparty/glibc.git/commit
localedef: Use initializer for flexible array member [BZ #24950]
authorFlorian Weimer <fweimer@redhat.com>
Tue, 3 Sep 2019 12:01:39 +0000 (14:01 +0200)
committerFlorian Weimer <fweimer@redhat.com>
Tue, 3 Sep 2019 12:01:47 +0000 (14:01 +0200)
commit1471fa556afb428c4a4c46cf5543a4101d5bcf91
treef74fdb5a42fb30bd7b7b56ae4c7bca3091489b51
parent9a1e7257a4292d3aea45c8317df3956f4331d8ce
localedef: Use initializer for flexible array member [BZ #24950]

struct charseq used a zero-length array instead of a flexible array
member.  This required a strange construct to initialize struct
charseq objects, and GCC 10 warns about that:

cc1: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
In file included from programs/repertoire.h:24,
                 from programs/localedef.h:32,
                 from programs/ld-ctype.c:35:
programs/charmap.h:63:17: note: destination object declared here
   63 |   unsigned char bytes[0];
      |                 ^~~~~
cc1: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
programs/charmap.h:63:17: note: destination object declared here
cc1: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
programs/charmap.h:63:17: note: destination object declared here
cc1: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
programs/charmap.h:63:17: note: destination object declared here

The change makes the object physically const, but it is not expected
to be modified.
ChangeLog
locale/programs/charmap.h
locale/programs/ld-ctype.c