]> git.ipfire.org Git - thirdparty/glibc.git/commit
realloc: Limit chunk reuse to only growing requests [BZ #30579]
authorSiddhesh Poyarekar <siddhesh@sourceware.org>
Thu, 6 Jul 2023 15:09:44 +0000 (11:09 -0400)
committerSiddhesh Poyarekar <siddhesh@sourceware.org>
Thu, 6 Jul 2023 15:10:27 +0000 (11:10 -0400)
commit2fb12bbd092b0c10f1f2083216e723d2406e21c4
tree00a2c18863e3248148c39fc8c362f74818919531
parent320ac7eeb47671e03ee26d4419b640fac0312390
realloc: Limit chunk reuse to only growing requests [BZ #30579]

The trim_threshold is too aggressive a heuristic to decide if chunk
reuse is OK for reallocated memory; for repeated small, shrinking
allocations it leads to internal fragmentation and for repeated larger
allocations that fragmentation may blow up even worse due to the dynamic
nature of the threshold.

Limit reuse only when it is within the alignment padding, which is 2 *
size_t for heap allocations and a page size for mmapped allocations.
There's the added wrinkle of THP, but this fix ignores it for now,
pessimizing that case in favor of keeping fragmentation low.

This resolves BZ #30579.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reported-by: Nicolas Dusart <nicolas@freedelity.be>
Reported-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
malloc/malloc.c