]> git.ipfire.org Git - thirdparty/glibc.git/commit
nscd: Drop local address tuple variable [BZ #29607]
authorSiddhesh Poyarekar <siddhesh@sourceware.org>
Tue, 4 Oct 2022 22:40:25 +0000 (18:40 -0400)
committerSiddhesh Poyarekar <siddhesh@sourceware.org>
Tue, 4 Oct 2022 22:40:25 +0000 (18:40 -0400)
commit6e33e5c4b73cea7b8aa3de0947123db16200fb65
treed1911dcb8aa26e4bf31899bc78c6b1c854ac0a9b
parent1f3f0060a1c9bd050a5e391352d3a95a25054861
nscd: Drop local address tuple variable [BZ #29607]

When a request needs to be resent (e.g. due to insufficient buffer
space), the references to subsequent tuples in the local variable are
stale and should not be used.  This used to work by accident before, but
since 1d495912a it no longer does.  Instead of trying to reset it, just
let gethostbyname4_r write into TUMPBUF6 for us, thus maintaining a
consistent state at all times.  This is now consistent with what is done
in gaih_inet for getaddrinfo.

Resolves: BZ #29607
Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
nscd/aicache.c