]> git.ipfire.org Git - thirdparty/glibc.git/commit
assert: Do not use stderr in libc-internal assert
authorFlorian Weimer <fweimer@redhat.com>
Wed, 3 Aug 2022 09:41:53 +0000 (11:41 +0200)
committerFlorian Weimer <fweimer@redhat.com>
Wed, 3 Aug 2022 09:43:04 +0000 (11:43 +0200)
commit9001cb1102cddba54f0e84e147dfbb0356067356
tree752100897824af704ceb553e42867960e41a87f7
parent68e036f27f31c3378201702e182246504fb00f87
assert: Do not use stderr in libc-internal assert

Redirect internal assertion failures to __libc_assert_fail, based on
based on __libc_message, which writes directly to STDERR_FILENO
and calls abort.  Also disable message translation and reword the
error message slightly (adjusting stdlib/tst-bz20544 accordingly).

As a result of these changes, malloc no longer needs its own
redefinition of __assert_fail.

__libc_assert_fail needs to be stubbed out during rtld dependency
analysis because the rtld rebuilds turn __libc_assert_fail into
__assert_fail, which is unconditionally provided by elf/dl-minimal.c.

This change is not possible for the public assert macro and its
__assert_fail function because POSIX requires that the diagnostic
is written to stderr.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
assert/Makefile
assert/__libc_assert_fail.c [new file with mode: 0644]
assert/assert.c
elf/Makefile
include/assert.h
malloc/malloc.c
stdlib/tst-bz20544.c