]> git.ipfire.org Git - thirdparty/glibc.git/commit
Fix build warnings in locale/programs/ld-ctype.c
authorStefan Liebler <stli@linux.ibm.com>
Wed, 26 Jun 2019 06:34:25 +0000 (08:34 +0200)
committerStefan Liebler <stli@linux.ibm.com>
Wed, 26 Jun 2019 06:34:25 +0000 (08:34 +0200)
commit9e6a7d9c179650478c8c34b8cf81a7699dc2ffe3
tree2eca6d9ea70b431da63855e4dbba4f7a09b04713
parentc89e669a70f28389897d0283cc8cb71e8068aaae
Fix build warnings in locale/programs/ld-ctype.c

This patch fixes the gcc warnings seen with gcc 9 -march>=z13 on s390x:
programs/ld-ctype.c: In function ‘ctype_read’:
programs/ld-ctype.c:1392:13: error: ‘wch’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1392 |    uint32_t wch;
      |             ^~~
programs/ld-ctype.c:1401:7: error: ‘seq’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1401 |    if (seq != NULL && seq->nbytes == 1)
      |       ^
programs/ld-ctype.c:1391:20: note: ‘seq’ was declared here
 1391 |    struct charseq *seq;
      |                    ^~~

Both seq and wch are uninitialized if get_character fails.
Thus we are now returning with an error.

ChangeLog:

* locale/programs/ld-ctype.c (charclass_symbolic_ellipsis):
Return error if get_character fails.
ChangeLog
locale/programs/ld-ctype.c