]> git.ipfire.org Git - thirdparty/glibc.git/commit
Add narrowing fma functions
authorJoseph Myers <joseph@codesourcery.com>
Wed, 22 Sep 2021 21:25:31 +0000 (21:25 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Wed, 22 Sep 2021 21:25:31 +0000 (21:25 +0000)
commitb3f27d8150d4f3c64063a9a257ec1d228de66398
tree23ea73de01b3e4f37fdc9152d6ffa90f4ba917e6
parentb413280cfb16834450f66f554bc0d618bb513851
Add narrowing fma functions

This patch adds the narrowing fused multiply-add functions from TS
18661-1 / TS 18661-3 / C2X to glibc's libm: ffma, ffmal, dfmal,
f32fmaf64, f32fmaf32x, f32xfmaf64 for all configurations; f32fmaf64x,
f32fmaf128, f64fmaf64x, f64fmaf128, f32xfmaf64x, f32xfmaf128,
f64xfmaf128 for configurations with _Float64x and _Float128;
__f32fmaieee128 and __f64fmaieee128 aliases in the powerpc64le case
(for calls to ffmal and dfmal when long double is IEEE binary128).
Corresponding tgmath.h macro support is also added.

The changes are mostly similar to those for the other narrowing
functions previously added, especially that for sqrt, so the
description of those generally applies to this patch as well.  As with
sqrt, I reused the same test inputs in auto-libm-test-in as for
non-narrowing fma rather than adding extra or separate inputs for
narrowing fma.  The tests in libm-test-narrow-fma.inc also follow
those for non-narrowing fma.

The non-narrowing fma has a known bug (bug 6801) that it does not set
errno on errors (overflow, underflow, Inf * 0, Inf - Inf).  Rather
than fixing this or having narrowing fma check for errors when
non-narrowing does not (complicating the cases when narrowing fma can
otherwise be an alias for a non-narrowing function), this patch does
not attempt to check for errors from narrowing fma and set errno; the
CHECK_NARROW_FMA macro is still present, but as a placeholder that
does nothing, and this missing errno setting is considered to be
covered by the existing bug rather than needing a separate open bug.
missing-errno annotations are duly added to many of the
auto-libm-test-in test inputs for fma.

This completes adding all the new functions from TS 18661-1 to glibc,
so will be followed by corresponding stdc-predef.h changes to define
__STDC_IEC_60559_BFP__ and __STDC_IEC_60559_COMPLEX__, as the support
for TS 18661-1 will be at a similar level to that for C standard
floating-point facilities up to C11 (pragmas not implemented, but
library functions done).  (There are still further changes to be done
to implement changes to the types of fromfp functions from N2548.)

Tested as followed: natively with the full glibc testsuite for x86_64
(GCC 11, 7, 6) and x86 (GCC 11); with build-many-glibcs.py with GCC
11, 7 and 6; cross testing of math/ tests for powerpc64le, powerpc32
hard float, mips64 (all three ABIs, both hard and soft float).  The
different GCC versions are to cover the different cases in tgmath.h
and tgmath.h tests properly (GCC 6 has _Float* only as typedefs in
glibc headers, GCC 7 has proper _Float* support, GCC 8 adds
__builtin_tgmath).
82 files changed:
NEWS
manual/arith.texi
math/Makefile
math/Versions
math/auto-libm-test-in
math/auto-libm-test-out-fma
math/auto-libm-test-out-narrow-fma [new file with mode: 0644]
math/bits/mathcalls-narrow.h
math/gen-tgmath-tests.py
math/libm-test-driver.c
math/libm-test-narrow-fma.inc [new file with mode: 0644]
math/math-narrow.h
math/s_fma.c
math/s_fmal.c
math/tgmath.h
sysdeps/i386/i686/multiarch/s_fma.c
sysdeps/ia64/fpu/s_fma.S
sysdeps/ia64/fpu/s_fmal.S
sysdeps/ieee754/dbl-64/s_f32xfmaf64.c [new file with mode: 0644]
sysdeps/ieee754/dbl-64/s_ffma.c [new file with mode: 0644]
sysdeps/ieee754/dbl-64/s_fma.c
sysdeps/ieee754/float128/float128_private.h
sysdeps/ieee754/float128/s_f32fmaf128.c [new file with mode: 0644]
sysdeps/ieee754/float128/s_f64fmaf128.c [new file with mode: 0644]
sysdeps/ieee754/float128/s_f64xfmaf128.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-128/s_dfmal.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-128/s_f64xfmaf128.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-128/s_ffmal.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-128/s_fma.c
sysdeps/ieee754/ldbl-128/s_fmal.c
sysdeps/ieee754/ldbl-128ibm-compat/Versions
sysdeps/ieee754/ldbl-128ibm/s_dfmal.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-128ibm/s_ffmal.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-96/s_dfmal.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-96/s_ffmal.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-96/s_fma.c
sysdeps/ieee754/ldbl-opt/Makefile
sysdeps/ieee754/ldbl-opt/nldbl-dfma.c [new file with mode: 0644]
sysdeps/ieee754/ldbl-opt/nldbl-ffma.c [new file with mode: 0644]
sysdeps/ieee754/soft-fp/s_dfmal.c [new file with mode: 0644]
sysdeps/ieee754/soft-fp/s_ffma.c [new file with mode: 0644]
sysdeps/ieee754/soft-fp/s_ffmal.c [new file with mode: 0644]
sysdeps/ieee754/soft-fp/s_fma.c
sysdeps/ieee754/soft-fp/s_fmal.c
sysdeps/mach/hurd/i386/libm.abilist
sysdeps/powerpc/fpu/libm-test-ulps
sysdeps/powerpc/powerpc64/le/fpu/multiarch/float128-ifunc-macros.h
sysdeps/powerpc/powerpc64/le/fpu/multiarch/float128-ifunc.h
sysdeps/riscv/rvd/s_fma.c
sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fma.c
sysdeps/sparc/sparc64/fpu/multiarch/s_fma.c
sysdeps/unix/sysv/linux/aarch64/libm.abilist
sysdeps/unix/sysv/linux/alpha/libm.abilist
sysdeps/unix/sysv/linux/arc/libm.abilist
sysdeps/unix/sysv/linux/arm/be/libm.abilist
sysdeps/unix/sysv/linux/arm/le/libm.abilist
sysdeps/unix/sysv/linux/csky/libm.abilist
sysdeps/unix/sysv/linux/hppa/libm.abilist
sysdeps/unix/sysv/linux/i386/libm.abilist
sysdeps/unix/sysv/linux/ia64/libm.abilist
sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist
sysdeps/unix/sysv/linux/m68k/m680x0/libm.abilist
sysdeps/unix/sysv/linux/microblaze/be/libm.abilist
sysdeps/unix/sysv/linux/microblaze/le/libm.abilist
sysdeps/unix/sysv/linux/mips/mips32/libm.abilist
sysdeps/unix/sysv/linux/mips/mips64/libm.abilist
sysdeps/unix/sysv/linux/nios2/libm.abilist
sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist
sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist
sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist
sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist
sysdeps/unix/sysv/linux/riscv/rv32/libm.abilist
sysdeps/unix/sysv/linux/riscv/rv64/libm.abilist
sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist
sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist
sysdeps/unix/sysv/linux/sh/be/libm.abilist
sysdeps/unix/sysv/linux/sh/le/libm.abilist
sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist
sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist
sysdeps/unix/sysv/linux/x86_64/64/libm.abilist
sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist
sysdeps/x86_64/fpu/multiarch/s_fma.c