]> git.ipfire.org Git - thirdparty/glibc.git/commit
New pthread rwlock that is more scalable.
authorTorvald Riegel <triegel@redhat.com>
Thu, 22 May 2014 14:00:12 +0000 (16:00 +0200)
committerTorvald Riegel <triegel@redhat.com>
Tue, 10 Jan 2017 10:50:17 +0000 (11:50 +0100)
commitcc25c8b4c1196a8c29e9a45b1e096b99a87b7f8c
tree52c5358896bc1ce9ad2081f179e72a1edac5fa6f
parentfbb31e20bc41957c5f3d6550f0178590cf473043
New pthread rwlock that is more scalable.

This replaces the pthread rwlock with a new implementation that uses a
more scalable algorithm (primarily through not using a critical section
anymore to make state changes).  The fast path for rdlock acquisition and
release is now basically a single atomic read-modify write or CAS and a few
branches.  See nptl/pthread_rwlock_common.c for details.

* nptl/DESIGN-rwlock.txt: Remove.
* nptl/lowlevelrwlock.sym: Remove.
* nptl/Makefile: Add new tests.
* nptl/pthread_rwlock_common.c: New file.  Contains the new rwlock.
* nptl/pthreadP.h (PTHREAD_RWLOCK_PREFER_READER_P): Remove.
(PTHREAD_RWLOCK_WRPHASE, PTHREAD_RWLOCK_WRLOCKED,
PTHREAD_RWLOCK_RWAITING, PTHREAD_RWLOCK_READER_SHIFT,
PTHREAD_RWLOCK_READER_OVERFLOW, PTHREAD_RWLOCK_WRHANDOVER,
PTHREAD_RWLOCK_FUTEX_USED): New.
* nptl/pthread_rwlock_init.c (__pthread_rwlock_init): Adapt to new
implementation.
* nptl/pthread_rwlock_rdlock.c (__pthread_rwlock_rdlock_slow): Remove.
(__pthread_rwlock_rdlock): Adapt.
* nptl/pthread_rwlock_timedrdlock.c
(pthread_rwlock_timedrdlock): Adapt.
* nptl/pthread_rwlock_timedwrlock.c
(pthread_rwlock_timedwrlock): Adapt.
* nptl/pthread_rwlock_trywrlock.c (pthread_rwlock_trywrlock): Adapt.
* nptl/pthread_rwlock_tryrdlock.c (pthread_rwlock_tryrdlock): Adapt.
* nptl/pthread_rwlock_unlock.c (pthread_rwlock_unlock): Adapt.
* nptl/pthread_rwlock_wrlock.c (__pthread_rwlock_wrlock_slow): Remove.
(__pthread_rwlock_wrlock): Adapt.
* nptl/tst-rwlock10.c: Adapt.
* nptl/tst-rwlock11.c: Adapt.
* nptl/tst-rwlock17.c: New file.
* nptl/tst-rwlock18.c: New file.
* nptl/tst-rwlock19.c: New file.
* nptl/tst-rwlock2b.c: New file.
* nptl/tst-rwlock8.c: Adapt.
* nptl/tst-rwlock9.c: Adapt.
* sysdeps/aarch64/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/arm/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/hppa/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/ia64/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/m68k/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/microblaze/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/mips/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/nios2/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/s390/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/sh/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/sparc/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/tile/nptl/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* sysdeps/unix/sysv/linux/alpha/bits/pthreadtypes.h
(pthread_rwlock_t): Adapt.
* sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h
(pthread_rwlock_t): Adapt.
* sysdeps/x86/bits/pthreadtypes.h (pthread_rwlock_t): Adapt.
* nptl/nptl-printers.py (): Adapt.
* nptl/nptl_lock_constants.pysym: Adapt.
* nptl/test-rwlock-printers.py: Adapt.
* nptl/test-rwlockattr-printers.c: Adapt.
* nptl/test-rwlockattr-printers.py: Adapt.
42 files changed:
ChangeLog
nptl/DESIGN-rwlock.txt [deleted file]
nptl/Makefile
nptl/lowlevelrwlock.sym [deleted file]
nptl/nptl-printers.py
nptl/nptl_lock_constants.pysym
nptl/pthreadP.h
nptl/pthread_rwlock_common.c [new file with mode: 0644]
nptl/pthread_rwlock_init.c
nptl/pthread_rwlock_rdlock.c
nptl/pthread_rwlock_timedrdlock.c
nptl/pthread_rwlock_timedwrlock.c
nptl/pthread_rwlock_tryrdlock.c
nptl/pthread_rwlock_trywrlock.c
nptl/pthread_rwlock_unlock.c
nptl/pthread_rwlock_wrlock.c
nptl/test-rwlock-printers.py
nptl/test-rwlockattr-printers.c
nptl/test-rwlockattr-printers.py
nptl/tst-rwlock10.c
nptl/tst-rwlock11.c
nptl/tst-rwlock17.c [new file with mode: 0644]
nptl/tst-rwlock18.c [new file with mode: 0644]
nptl/tst-rwlock19.c [new file with mode: 0644]
nptl/tst-rwlock2b.c [new file with mode: 0644]
nptl/tst-rwlock8.c
nptl/tst-rwlock9.c
sysdeps/aarch64/nptl/bits/pthreadtypes.h
sysdeps/arm/nptl/bits/pthreadtypes.h
sysdeps/hppa/nptl/bits/pthreadtypes.h
sysdeps/ia64/nptl/bits/pthreadtypes.h
sysdeps/m68k/nptl/bits/pthreadtypes.h
sysdeps/microblaze/nptl/bits/pthreadtypes.h
sysdeps/mips/nptl/bits/pthreadtypes.h
sysdeps/nios2/nptl/bits/pthreadtypes.h
sysdeps/s390/nptl/bits/pthreadtypes.h
sysdeps/sh/nptl/bits/pthreadtypes.h
sysdeps/sparc/nptl/bits/pthreadtypes.h
sysdeps/tile/nptl/bits/pthreadtypes.h
sysdeps/unix/sysv/linux/alpha/bits/pthreadtypes.h
sysdeps/unix/sysv/linux/powerpc/bits/pthreadtypes.h
sysdeps/x86/bits/pthreadtypes.h