]> git.ipfire.org Git - thirdparty/glibc.git/commit
Fix alignment of TLS variables for tls variant TLS_TCB_AT_TP [BZ #23403]
authorStefan Liebler <stli@linux.ibm.com>
Wed, 6 Feb 2019 08:06:34 +0000 (09:06 +0100)
committerDJ Delorie <dj@redhat.com>
Wed, 6 Nov 2019 22:40:18 +0000 (17:40 -0500)
commitcedb3e47c68d319607736a820da2d5b3b8ddff6f
tree24970e23d7f3b66c54bed1e2891c7905828bd521
parentfe7c01cb14bd78943eb6c6a483f59299b7aebdc0
Fix alignment of TLS variables for tls variant TLS_TCB_AT_TP [BZ #23403]

The alignment of TLS variables is wrong if accessed from within a thread
for architectures with tls variant TLS_TCB_AT_TP.
For the main thread the static tls data is properly aligned.
For other threads the alignment depends on the alignment of the thread
pointer as the static tls data is located relative to this pointer.

This patch adds this alignment for TLS_TCB_AT_TP variants in the same way
as it is already done for TLS_DTV_AT_TP. The thread pointer is also already
properly aligned if the user provides its own stack for the new thread.

This patch extends the testcase nptl/tst-tls1.c in order to check the
alignment of the tls variables and it adds a pthread_create invocation
with a user provided stack.
The test itself is migrated from test-skeleton.c to test-driver.c
and the missing support functions xpthread_attr_setstack and xposix_memalign
are added.

ChangeLog:

[BZ #23403]
* nptl/allocatestack.c (allocate_stack): Align pointer pd for
TLS_TCB_AT_TP tls variant.
* nptl/tst-tls1.c: Migrate to support/test-driver.c.
Add alignment checks.
* support/Makefile (libsupport-routines): Add xposix_memalign and
xpthread_setstack.
* support/support.h: Add xposix_memalign.
* support/xthread.h: Add xpthread_attr_setstack.
* support/xposix_memalign.c: New File.
* support/xpthread_attr_setstack.c: Likewise.

(cherry picked from commit bc79db3fd487daea36e7c130f943cfb9826a41b4)
ChangeLog
nptl/allocatestack.c
nptl/tst-tls1.c
support/Makefile
support/support.h
support/xposix_memalign.c [new file with mode: 0644]
support/xpthread_attr_setstack.c [new file with mode: 0644]
support/xthread.h