]> git.ipfire.org Git - thirdparty/glibc.git/commit
Bug 20116: Fix use after free in pthread_create()
authorCarlos O'Donell <carlos@redhat.com>
Sun, 29 Jan 2017 00:13:34 +0000 (19:13 -0500)
committerAurelien Jarno <aurelien@aurel32.net>
Sat, 29 Dec 2018 00:35:01 +0000 (01:35 +0100)
commitfcd316654a4510281fff32194b3b9f90e3dfab83
treec36afd14a49ef16dfff7b8743c4e982c0a5f655e
parente853f05a5757dfee0c8b7f301e6a52047cc9864a
Bug 20116: Fix use after free in pthread_create()

The commit documents the ownership rules around 'struct pthread' and
when a thread can read or write to the descriptor. With those ownership
rules in place it becomes obvious that pd->stopped_start should not be
touched in several of the paths during thread startup, particularly so
for detached threads. In the case of detached threads, between the time
the thread is created by the OS kernel and the creating thread checks
pd->stopped_start, the detached thread might have already exited and the
memory for pd unmapped. As a regression test we add a simple test which
exercises this exact case by quickly creating detached threads with
large enough stacks to ensure the thread stack cache is bypassed and the
stacks are unmapped. Before the fix the testcase segfaults, after the
fix it works correctly and completes without issue.

For a detailed discussion see:
https://www.sourceware.org/ml/libc-alpha/2017-01/msg00505.html

(cherry picked from commit f8bf15febcaf137bbec5a61101e88cd5a9d56ca8)
12 files changed:
ChangeLog
NEWS
nptl/Makefile
nptl/createthread.c
nptl/pthread_create.c
nptl/pthread_getschedparam.c
nptl/pthread_setschedparam.c
nptl/pthread_setschedprio.c
nptl/tpp.c
nptl/tst-create-detached.c [new file with mode: 0644]
sysdeps/nacl/createthread.c
sysdeps/unix/sysv/linux/createthread.c