]> git.ipfire.org Git - thirdparty/glibc.git/log
thirdparty/glibc.git
2 years agoUpdate ChangeLog.old/ChangeLog.23. glibc-2.34
Carlos O'Donell [Mon, 2 Aug 2021 01:33:43 +0000 (21:33 -0400)] 
Update ChangeLog.old/ChangeLog.23.

2 years agoPrepare for glibc 2.34 release.
Carlos O'Donell [Mon, 2 Aug 2021 01:24:04 +0000 (21:24 -0400)] 
Prepare for glibc 2.34 release.

Update version.h, and include/features.h.

2 years agopo/nl.po: Update Dutch translation.
Carlos O'Donell [Mon, 2 Aug 2021 00:47:29 +0000 (20:47 -0400)] 
po/nl.po: Update Dutch translation.

2 years agoUpdate install.texi, and regenerate INSTALL.
Carlos O'Donell [Sun, 1 Aug 2021 20:36:25 +0000 (16:36 -0400)] 
Update install.texi, and regenerate INSTALL.

2 years agoUpdate translations.
Carlos O'Donell [Sun, 1 Aug 2021 03:24:51 +0000 (23:24 -0400)] 
Update translations.

2 years agoUpdate NEWS.
Carlos O'Donell [Sun, 1 Aug 2021 03:39:07 +0000 (23:39 -0400)] 
Update NEWS.

Suggestions by Florian Weimer, Andreas Schwab, and Alexander Monakov.

See:
https://sourceware.org/pipermail/libc-alpha/2021-July/129356.html
https://sourceware.org/pipermail/libc-alpha/2021-July/129357.html
https://sourceware.org/pipermail/libc-alpha/2021-July/129361.html

2 years agoNEWS: Fix typos, grammar, and missing words
Mark Harris [Sat, 31 Jul 2021 23:25:57 +0000 (16:25 -0700)] 
NEWS: Fix typos, grammar, and missing words

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agoelf: Fix audit regression
Adhemerval Zanella [Wed, 30 Jun 2021 03:21:18 +0000 (00:21 -0300)] 
elf: Fix audit regression

Commit 03e187a41d9 added a regression when an audit module does not have
libc as DT_NEEDED (although unusual it is possible).

Checked on x86_64-linux-gnu.

2 years agoUpdate libc.pot for 2.34 release.
Carlos O'Donell [Thu, 29 Jul 2021 02:03:54 +0000 (22:03 -0400)] 
Update libc.pot for 2.34 release.

2 years agox86-64: Add Avoid_Short_Distance_REP_MOVSB
H.J. Lu [Fri, 23 Jul 2021 03:26:25 +0000 (20:26 -0700)] 
x86-64: Add Avoid_Short_Distance_REP_MOVSB

commit 3ec5d83d2a237d39e7fd6ef7a0bc8ac4c171a4a5
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Jan 25 14:19:40 2020 -0800

    x86-64: Avoid rep movsb with short distance [BZ #27130]

introduced some regressions on Intel processors without Fast Short REP
MOV (FSRM).  Add Avoid_Short_Distance_REP_MOVSB to avoid rep movsb with
short distance only on Intel processors with FSRM.  bench-memmove-large
on Skylake server shows that cycles of __memmove_evex_unaligned_erms
improves for the following data size:

                                  before    after    Improvement
length=4127, align1=3, align2=0:  479.38    349.25      27%
length=4223, align1=9, align2=5:  405.62    333.25      18%
length=8223, align1=3, align2=0:  786.12    496.38      37%
length=8319, align1=9, align2=5:  727.50    501.38      31%
length=16415, align1=3, align2=0: 1436.88   840.00      41%
length=16511, align1=9, align2=5: 1375.50   836.38      39%
length=32799, align1=3, align2=0: 2890.00   1860.12     36%
length=32895, align1=9, align2=5: 2891.38   1931.88     33%

2 years agoTypo: Rename HAVE_CLONE3_WAPPER to HAVE_CLONE3_WRAPPER
H.J. Lu [Wed, 28 Jul 2021 17:19:08 +0000 (10:19 -0700)] 
Typo: Rename HAVE_CLONE3_WAPPER to HAVE_CLONE3_WRAPPER

2 years agobuild-many-glibcs.py: Add x86_64-linux-gnu-minimal configuration
Florian Weimer [Wed, 28 Jul 2021 12:47:33 +0000 (14:47 +0200)] 
build-many-glibcs.py: Add x86_64-linux-gnu-minimal configuration

This configuration exercises various --disable-* configure options.
It is expected to catch -Werror failures that only affect these
configurations.

2 years agotests: use xmalloc to allocate implementation array
Siddhesh Poyarekar [Wed, 28 Jul 2021 07:33:27 +0000 (13:03 +0530)] 
tests: use xmalloc to allocate implementation array

The benchmark and tests must fail in case of allocation failure in the
implementation array.  Also annotate the x* allocators in support.h so
that the compiler has more information about them.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
2 years agoxmalloc: Fix warnings with gcc analyzer
Siddhesh Poyarekar [Wed, 28 Jul 2021 11:28:17 +0000 (16:58 +0530)] 
xmalloc: Fix warnings with gcc analyzer

Tell the compiler that xmalloc family of allocators always return
non-NULL.  xrealloc in locale/programs also always returns non-NULL,
but that conflicts with default realloc behaviour and that of xrealloc
in libsupport, so keep it as is for now and resolve the differences
later.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
2 years ago__cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524]
Siddhesh Poyarekar [Wed, 28 Jul 2021 07:41:20 +0000 (13:11 +0530)] 
__cxa_thread_atexit_impl: Abort on allocation failure [BZ #18524]

Abort in the unlikely event that allocation fails when trying to
register a TLS destructor.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
2 years agomanual: Drop the .so suffix in libc_malloc_debug description
Siddhesh Poyarekar [Tue, 27 Jul 2021 02:24:46 +0000 (07:54 +0530)] 
manual: Drop the .so suffix in libc_malloc_debug description

All references to libraries in the manual are without the .so prefix,
so do the same for libc_malloc_debug.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agohurd: _Fork: unlock malloc before calling fork child hooks
Samuel Thibault [Tue, 27 Jul 2021 00:03:01 +0000 (02:03 +0200)] 
hurd: _Fork: unlock malloc before calling fork child hooks

The setitimer fork hook, fork_itimer, needs to call malloc inside
__mach_setup_tls, so we need to unlock malloc before calling it.

2 years agoExclude static tests for mcheck and malloc-check
Siddhesh Poyarekar [Mon, 26 Jul 2021 05:17:46 +0000 (10:47 +0530)] 
Exclude static tests for mcheck and malloc-check

mcheck and malloc-check no longer work with static binaries, so drop
those tests.

Reported-by: Samuel Thibault <samuel.thibault@gnu.org>
Tested-by: Samuel Thibault <samuel.thibault@gnu.org>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
2 years agoi386: Regenerate ulps
Arjun Shankar [Sun, 25 Jul 2021 20:29:27 +0000 (22:29 +0200)] 
i386: Regenerate ulps

These failures were caught while building glibc master for Fedora Rawhide
which is built with `-mtune=generic -msse2 -mfpmath=sse'.

2 years agomanual: Document unsupported cases for interposition
Siddhesh Poyarekar [Fri, 23 Jul 2021 14:56:01 +0000 (20:26 +0530)] 
manual: Document unsupported cases for interposition

These functions call the core allocator functions (realloc and malloc
respectively) and are hence guaranteed to allocate memory using the
correct functions when multiple allocators are interposed.  Having
these functions interposed in one allocator and not another may result
in confusion, hence discourage interposing them altogether.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
2 years agox86: Install <bits/platform/x86.h> [BZ #27958]
H.J. Lu [Sat, 5 Jun 2021 13:42:20 +0000 (06:42 -0700)] 
x86: Install <bits/platform/x86.h> [BZ #27958]

1. Install <bits/platform/x86.h> for <sys/platform/x86.h> which includes
<bits/platform/x86.h>.
2. Rename HAS_CPU_FEATURE to CPU_FEATURE_PRESENT which checks if the
processor has the feature.
3. Rename CPU_FEATURE_USABLE to CPU_FEATURE_ACTIVE which checks if the
feature is active.  There may be other preconditions, like sufficient
stack space or further setup for AMX, which must be satisfied before the
feature can be used.

This fixes BZ #27958.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agoFix build and tests with --disable-tunables
Siddhesh Poyarekar [Fri, 23 Jul 2021 08:27:56 +0000 (13:57 +0530)] 
Fix build and tests with --disable-tunables

Remove unused code and declare __libc_mallopt when !IS_IN (libc) to
allow the debug hook to build with --disable-tunables.

Also, run tst-ifunc-isa-2* tests only when tunables are enabled since
the result depends on it.

Tested on x86_64.

Reported-by: Matheus Castanho <msc@linux.ibm.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agohurd: Fix glob lstat compatibility
Samuel Thibault [Thu, 22 Jul 2021 18:29:57 +0000 (18:29 +0000)] 
hurd: Fix glob lstat compatibility

84f7ce84474c ("posix: Add glob64 with 64-bit time_t support") replaced
GLOB_NO_LSTAT with defining GLOB_LSTAT and GLOB_LSTAT64, but the posix
and gnu versions of the change were missing in the commit.

2 years agosocket: Add time64 alias for setsockopt
Florian Weimer [Thu, 22 Jul 2021 17:12:13 +0000 (19:12 +0200)] 
socket: Add time64 alias for setsockopt

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agosocket: Add time64 alias for getsockopt
Florian Weimer [Thu, 22 Jul 2021 17:12:12 +0000 (19:12 +0200)] 
socket: Add time64 alias for getsockopt

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agomcheck Fix malloc_usable_size [BZ #22057]
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:16 +0000 (18:38 +0530)] 
mcheck Fix malloc_usable_size [BZ #22057]

Interpose malloc_usable_size to return the correct mcheck value for
malloc_usable_size.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoRemove malloc hooks [BZ #23328]
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:12 +0000 (18:38 +0530)] 
Remove malloc hooks [BZ #23328]

Make malloc hooks symbols compat-only so that new applications cannot
link against them and remove the declarations from the API.  Also
remove the unused malloc-hooks.h.

Finally, mark all symbols in libc_malloc_debug.so as compat so that
the library cannot be linked against.

Add a note about the deprecation in NEWS.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoMove malloc_{g,s}et_state to libc_malloc_debug
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:10 +0000 (18:38 +0530)] 
Move malloc_{g,s}et_state to libc_malloc_debug

These deprecated functions are only safe to call from
__malloc_initialize_hook and as a result, are not useful in the
general case.  Move the implementations to libc_malloc_debug so that
existing binaries that need it will now have to preload the debug DSO
to work correctly.

This also allows simplification of the core malloc implementation by
dropping all the undumping support code that was added to make
malloc_set_state work.

One known breakage is that of ancient emacs binaries that depend on
this.  They will now crash when running with this libc.  With
LD_BIND_NOW=1, it will terminate immediately because of not being able
to find malloc_set_state but with lazy binding it will crash in
unpredictable ways.  It will need a preloaded libc_malloc_debug.so so
that its initialization hook is executed to allow its malloc
implementation to work properly.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoglibc.malloc.check: Wean away from malloc hooks
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:08 +0000 (18:38 +0530)] 
glibc.malloc.check: Wean away from malloc hooks

The malloc-check debugging feature is tightly integrated into glibc
malloc, so thanks to an idea from Florian Weimer, much of the malloc
implementation has been moved into libc_malloc_debug.so to support
malloc-check.  Due to this, glibc malloc and malloc-check can no
longer work together; they use altogether different (but identical)
structures for heap management.  This should not make a difference
though since the malloc check hook is not disabled anywhere.
malloc_set_state does, but it does so early enough that it shouldn't
cause any problems.

The malloc check tunable is now in the debug DSO and has no effect
when the DSO is not preloaded.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agomtrace: Wean away from malloc hooks
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:06 +0000 (18:38 +0530)] 
mtrace: Wean away from malloc hooks

Wean mtrace away from the malloc hooks and move them into the debug
DSO.  Split the API away from the implementation so that we can add
the API to libc.so as well as libc_malloc_debug.so, with the libc
implementations being empty.

Update localplt data since memalign no longer has any callers after
this change.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoSimplify __malloc_initialized
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:04 +0000 (18:38 +0530)] 
Simplify __malloc_initialized

Now that mcheck no longer needs to check __malloc_initialized (and no
other third party hook can since the symbol is not exported), make the
variable boolean and static so that it is used strictly within malloc.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agomcheck: Wean away from malloc hooks [BZ #23489]
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:08:02 +0000 (18:38 +0530)] 
mcheck: Wean away from malloc hooks [BZ #23489]

Split the mcheck implementation into the debugging hooks and API so
that the API can be replicated in libc and libc_malloc_debug.so.  The
libc APIs always result in failure.

The mcheck implementation has also been moved entirely into
libc_malloc_debug.so and with it, all of the hook initialization code
can now be moved into the debug library.  Now the initialization can
be done independently of libc internals.

With this patch, libc_malloc_debug.so can no longer be used with older
libcs, which is not its goal anyway.  tst-vfork3 breaks due to this
since it spawns shell scripts, which in turn execute using the system
glibc.  Move the test to tests-container so that only the built glibc
is used.

This move also fixes bugs in the mcheck version of memalign and
realloc, thus allowing removal of the tests from tests-mcheck
exclusion list.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoMove malloc hooks into a compat DSO
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:07:59 +0000 (18:37 +0530)] 
Move malloc hooks into a compat DSO

Remove all malloc hook uses from core malloc functions and move it
into a new library libc_malloc_debug.so.  With this, the hooks now no
longer have any effect on the core library.

libc_malloc_debug.so is a malloc interposer that needs to be preloaded
to get hooks functionality back so that the debugging features that
depend on the hooks, i.e. malloc-check, mcheck and mtrace work again.
Without the preloaded DSO these debugging features will be nops.
These features will be ported away from hooks in subsequent patches.

Similarly, legacy applications that need hooks functionality need to
preload libc_malloc_debug.so.

The symbols exported by libc_malloc_debug.so are maintained at exactly
the same version as libc.so.

Finally, static binaries will no longer be able to use malloc
debugging features since they cannot preload the debugging DSO.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoRemove __morecore and __default_morecore
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:07:57 +0000 (18:37 +0530)] 
Remove __morecore and __default_morecore

Make the __morecore and __default_morecore symbols compat-only and
remove their declarations from the API.  Also, include morecore.c
directly into malloc.c; this should ideally get merged into malloc in
a future cleanup.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoRemove __after_morecore_hook
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:07:54 +0000 (18:37 +0530)] 
Remove __after_morecore_hook

Remove __after_morecore_hook from the API and finalize the symbol so
that it can no longer be used in new applications.  Old applications
using __after_morecore_hook will find that their hook is no longer
called.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoMake mcheck tests conditional on GLIBC_2.23 or earlier
Siddhesh Poyarekar [Thu, 22 Jul 2021 13:07:41 +0000 (18:37 +0530)] 
Make mcheck tests conditional on GLIBC_2.23 or earlier

Targets with base versions of 2.24 or later won't have
__malloc_initialize_hook because of which the tests will essentially
be the same as the regular malloc tests.  Avoid running them instead
and save time.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoposix: Add sysconf(_SC_{MIN,}SIGSTKSZ) support
Samuel Thibault [Wed, 21 Jul 2021 23:23:02 +0000 (23:23 +0000)] 
posix: Add sysconf(_SC_{MIN,}SIGSTKSZ) support

2 years agomalloc: Fix tst-mallocfork3-malloc-check link
Samuel Thibault [Wed, 21 Jul 2021 22:40:57 +0000 (22:40 +0000)] 
malloc: Fix tst-mallocfork3-malloc-check link

It uses pthread.

2 years agoARC: elf: make type safe
Vineet Gupta [Thu, 30 Jul 2020 05:49:14 +0000 (22:49 -0700)] 
ARC: elf: make type safe

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
2 years agoARC: fp: (micro)optimize FPU_STATUS read by eliding FWE bit clearing
Vineet Gupta [Fri, 9 Jul 2021 21:56:18 +0000 (14:56 -0700)] 
ARC: fp: (micro)optimize FPU_STATUS read by eliding FWE bit clearing

Any FPU_STATUS write needs setting the FWE bit (31) whcih just provides
a "control signal" to enable explicit write (vs. the side-effect of FPU
instructions).  However this bit is RAZ and write-only, thus effectively
never stored in FPU_STATUS register. Thus when reading the register
there is no need to clear it. This shaves off a BCLR instruction from
the fe*exceptino family of functions and while no big deal still makes
sense to do.

This came up when debugging a race in math/test-fenv-tls [1]

[1]: https://github.com/foss-for-synopsys-dwc-arc-processors/linux/issues/54

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
2 years agosocket: Add time64 alias for sendmsg
Florian Weimer [Wed, 21 Jul 2021 09:42:31 +0000 (11:42 +0200)] 
socket: Add time64 alias for sendmsg

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agosocket: Add time64 alias for recvmsg
Florian Weimer [Wed, 21 Jul 2021 09:42:31 +0000 (11:42 +0200)] 
socket: Add time64 alias for recvmsg

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agosocket: Add time64 alias for sendmmsg
Florian Weimer [Wed, 21 Jul 2021 09:42:31 +0000 (11:42 +0200)] 
socket: Add time64 alias for sendmmsg

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agoLinux: Add time64 alias for prctl
Florian Weimer [Wed, 21 Jul 2021 09:42:31 +0000 (11:42 +0200)] 
Linux: Add time64 alias for prctl

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agoio: Add time64 alias for fcntl
Florian Weimer [Wed, 21 Jul 2021 09:42:31 +0000 (11:42 +0200)] 
io: Add time64 alias for fcntl

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agomisc: Add time64 alias for ioctl
Florian Weimer [Wed, 21 Jul 2021 09:42:31 +0000 (11:42 +0200)] 
misc: Add time64 alias for ioctl

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agoRISC-V: Update rv64 ULPs
Darius Rad [Tue, 20 Jul 2021 00:45:59 +0000 (20:45 -0400)] 
RISC-V: Update rv64 ULPs

Generated on a Microsemi Polarfire Icicle Kit running Linux version 5.6.18.
Same ULPs were also produced on QEMU 5.2.0 running Linux 5.10.46-1.

2 years agoresolv: Do not install libnss_dns.a, libnss_dns.so
Florian Weimer [Tue, 20 Jul 2021 10:27:23 +0000 (12:27 +0200)] 
resolv: Do not install libnss_dns.a, libnss_dns.so

Fixes commit e1fcf21474c5b522f ("resolv: Move nss_dns into libc").

2 years agohurd: Add support for spawn_do_closefrom
Samuel Thibault [Mon, 19 Jul 2021 21:45:29 +0000 (21:45 +0000)] 
hurd: Add support for spawn_do_closefrom

2 years agoelf: Fix tst-cpu-features-cpuinfo on some AMD systems (BZ #28090)
Adhemerval Zanella [Thu, 15 Jul 2021 11:52:44 +0000 (08:52 -0300)] 
elf: Fix tst-cpu-features-cpuinfo on some AMD systems (BZ #28090)

The SSBD feature is implemented in 2 different ways on AMD processors:
newer systems (Zen3) provides AMD_SSBD (function 8000_0008, EBX[24]),
while older system provides AMD_VIRT_SSBD (function 8000_0008, EBX[25]).
However for AMD_VIRT_SSBD, kernel shows both 'ssdb' and 'virt_ssdb' on
/proc/cpuinfo; while for AMD_SSBD only 'ssdb' is provided.

This now check is AMD_SSBD is set to check for 'ssbd', otherwise check
if AMD_VIRT_SSDB is set to check for 'virt_ssbd'.

Checked on x86_64-linux-gnu on a Ryzen 9 5900x.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
2 years agoi386: Add the clone3 wrapper
H.J. Lu [Wed, 12 May 2021 18:02:47 +0000 (11:02 -0700)] 
i386: Add the clone3 wrapper

extern int clone3 (struct clone_args *__cl_args, size_t __size,
   int (*__func) (void *__arg), void *__arg);

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agonss: Directly load nss_dns, without going through dlsym/dlopen
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
nss: Directly load nss_dns, without going through dlsym/dlopen

This partially fixes static-only NSS support (bug 27959): The dns
module no longer needs dlopen.  Support for disabling dlopen altogher
remains to be added.

This commit introduces module_load_builtin into nss/nss_module.c, which
handles the common parts of loading the built-in nss_files and nss_dns
modules.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move nss_dns into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move nss_dns into libc

No abilist updates are needed because the symbols were GLIBC_PRIVATE.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_query functions into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_query functions into libc

This switches to public symbols without __ prefixes, due to improved
namespace management in glibc.

The script was used with --no-new-version to move the symbols
__res_nquery, __res_nquerydomain, __res_nsearch, __res_query,
__res_querydomain, __res_search, res_query, res_querydomain,
res_search.  The public symbols res_nquery, res_nquerydomain,
res_nsearch, res_ownok, res_query, res_querydomain, res_search
were added with make update-all-abi.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_mkquery, res_nmkquery into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_mkquery, res_nmkquery into libc

This switches to public symbols without __ prefixes, due to improved
namespace management in glibc.

The symbols res_mkquery, __res_mkquery, __res_nmkquery were
moved with the script (using --no-new-version).
res_mkquery@@GLIBC_2.34, res_nmkquery@@GLIBC_2.34 were added using
make update-all-abi.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_send, res_nsend into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_send, res_nsend into libc

Switch to public symbols without __ prefix (due to improved
namespace management).

__res_send, __res_nsend were moved using the script (with
--no-new-version).  res_send@@GLIBC_2.34 and res_nsend@@GLIBC_2.34
were added using make update-all-abi.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_hostalias into its own file, along with hostalias
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_hostalias into its own file, along with hostalias

These deprecated symbols continue to be exported from libresolv.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move __res_context_hostalias into its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move __res_context_hostalias into its own file and into libc

And reformat it to GNU style.  Remove the unecessary setbuf call.
Use __fgets_unlocked for PLT avoidance; no locking is required here.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_queriesmatch to its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_queriesmatch to its own file and into libc

And reformat it to GNU style.

The treatment of this function matches res_nameinquery, for the
reasons stated there.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_nameinquery to its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_nameinquery to its own file and into libc

And reformat to GNU style.

This deprecated function is used in the implementation of the stub
resolver (for now).  Keep the public symbol in libresolv for now
(so that no new symbol version is needed), and add a forwarder to
libresolv.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_samename into its own file, and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_samename into its own file, and into libc

But only as an internal symbol, __libc_ns_samename.  The libresolv
ABI is preserved.  This is because the function is deprecated, and
it does not make sense to add new symbol versions for deprecated
functions.

Also reformat the implementation to GNU style.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_makecanon into its own file, and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_makecanon into its own file, and into libc

But only as an internal symbol, __libc_ns_makecanon.  The libresolv
ABI is preserved.  This is because the function is deprecated, and
it does not make sense to add new symbol versions for deprecated
functions.

Also reformat the implementation to GNU style.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move res_isourserver to its own file and reformat to GNU style
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move res_isourserver to its own file and reformat to GNU style

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move __res_get_nsaddr to its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move __res_get_nsaddr to its own file and into libc

Eliminate the use of the EXT macro from it because it does not
add clarity.  The function was added to res_send.c in 2015, and
the copyright year reflects that.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Rename res_comp.c to res-name-checking.c and move into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Rename res_comp.c to res-name-checking.c and move into libc

This reflects what the remaining functions in the file do.

The __res_dnok, __res_hnok, __res_mailok, __res_ownok were moved
with the script, using --no-new-version, and turned into compat
symbols.  __libc_res_dnok@@GLIBC_PRIVATE and
__libc_res_hnok@@GLIBC_PRIVATE are added for internal use, to avoid
accidentally binding to compatibility symbols.  The new public
symbols res_dnok, res_hnok, res_mailok, res_ownok were added using
make update-all-abi.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move dn_skipname to its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move dn_skipname to its own file and into libc

And reformat it to GNU style.

dn_skipname is used outside glibc, so do not deprecate it,
and export it as dn_skipname (not __dn_skipname).  Due to internal
users, provide a __libc_dn_skipname alias, and keep __dn_skipname
as a pure compatibility symbol.

__dn_skipname@GLIBC_2.0 was moved using the script, and
dn_skipname@@GLIBC_2.34 was added using make update-all-abi.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move dn_comp to its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move dn_comp to its own file and into libc

And reformat it to GNU style.

dn_comp is used in various programs, so keep it as a non-deprecated
symbol.  Switch to dn_comp (not __dn_comp) for the ABI name.  There
are no internal users, so interposition is not a problem.

The __dn_comp symbol was moved with scripts/move-symbol-to-libc.py
--no-new-version.  dn_comp@@GLIBC_2.34 was added with
make update-all-abi.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move _getlong, _getshort, __putlong, __putshort to res-putget
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move _getlong, _getshort, __putlong, __putshort to res-putget

And reformat to GNU style.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move dn_expand to its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move dn_expand to its own file and into libc

And reformat to GNU style.

This switches back to the dn_expand name for the ABI symbol and turns
__dn_expand into a compatibility symbol.  With the improved namespace
management in current glibc, it is no longer necessary to use a
private namespace symbol.  To avoid old code binding to a
GLIBC_PRIVATE symbol by accident, use __libc_dn_expand for the
internal symbol name.

The symbols dn_expand, __dnexpand were moved using
scripts/move-symbol-to-libc.py, followed by an adjustment to make
dn_expand the only GLIBC_2.34 symbol.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_name_compress into its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_name_compress into its own file and into libc

And reformat to GNU style.

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_name_pack into its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_name_pack into its own file and into libc

And reformat to GNU style, and eliminate the labellen function.

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_name_pton into its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_name_pton into its own file and into libc

And reformat to GNU style, and eliminate the digits variable.

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_name_uncompress into its own file and into libc
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_name_uncompress into its own file and into libc

And reformat to GNU style.  Check for negative error returns
(instead of -1).

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_name_skip to its own file and into libc (bug 28091)
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Move ns_name_skip to its own file and into libc (bug 28091)

And reformat to GNU style.  Avoid out-of-bounds pointer arithmetic.
This also results in a fix of bug 28091 due to the additional packet
length checks.

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@systemhalted.org>
2 years agoresolv: Deprecate legacy interfaces in libresolv
Florian Weimer [Mon, 19 Jul 2021 05:55:27 +0000 (07:55 +0200)] 
resolv: Deprecate legacy interfaces in libresolv

Debugging interfaces: p_*, fp_*, and sym_* could conceivably be
used to produce debug out, but these functions have not been
updated to parse more resource records, so they are not very useful
today.  Likewise for ns_sprintrr and ns_sprintrrf.  ns_format_ttl and
ns_parse_ttl are related to these.

Internal implementation details: res_isourserver is probably only
useful in the implementation of a stub resolver, and so is
res_nameinquery.

Unclear semantics and bad performance: ns_samedomain, ns_subdomain,
ns_makecanon, ns_samename do textual converions & copies instead of
checking equivalence of the wire format.

inet_neta cannot handle IPv6 addresses.

res_hostalias has been superseded by getaddrinfo with AI_CANONNAME.
hostalias is not thread-safe.

Some functions have int as size arguments instead of size_t, so they
do not follow current coding practices.  However, dn_expand and
b64_ntop are somewhat widely used (to name just two examples), so
deprecating them seems problematic.

Reviewed-by: Carlos O'Donell <carlos@systemhalted.org>
2 years agotst-safe-linking: make false positives even more improbable
Siddhesh Poyarekar [Mon, 19 Jul 2021 02:59:25 +0000 (08:29 +0530)] 
tst-safe-linking: make false positives even more improbable

There is a 1 in 16 chance of a corruption escaping safe-linking and to
guard against spurious failures, tst-safe-linking runs each subtest 10
times to ensure that the chance is reduced to 1 in 2^40.  However, in
the 1 in 16 chance that a corruption does escape safe linking, it
could well be caught by other sanity checks we do in malloc, which
then results in spurious test failures like below:

test test_fastbin_consolidate failed with a different error
  expected: malloc_consolidate(): unaligned fastbin chunk detected

  actual:   malloc_consolidate(): invalid chunk size

This failure is seen more frequently on i686; I was able to reproduce
it in about 5 min of running it in a loop.

Guard against such failures by recording them and retrying the test.
Also, do not fail the test if we happened to get defeated by the 1 in
2^40 odds if in at least one of the instances it was detected by other
checks.

Finally, bolster the odds to 2^64 by running 16 times instead of 10.
The test still has a chance of failure so it is still flaky in theory.
However in practice if we see a failure here then it's more likely
that there's a bug than it being an issue with the test.  Add more
printfs and also dump them to stdout so that in the event the test
actually fails, we will have some data to try and understand why it
may have failed.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agohtl: Do not expose pthread hidden proto outside libpthread
Samuel Thibault [Sun, 18 Jul 2021 20:25:33 +0000 (20:25 +0000)] 
htl: Do not expose pthread hidden proto outside libpthread

Only libpthread.so can access them.

2 years agoelf: Fix a wrong array access on tst-tls20
Adhemerval Zanella [Fri, 16 Jul 2021 11:32:05 +0000 (08:32 -0300)] 
elf: Fix a wrong array access on tst-tls20

Check on x86_64-linux-gnu with --enable-stack-protector=all.

2 years agoelf: Add -Wl,--no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089)
Adhemerval Zanella [Thu, 15 Jul 2021 11:18:21 +0000 (08:18 -0300)] 
elf: Add -Wl,--no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089)

The tests explicit requires the dependencies and it is required for
the case the toolchain defaults to -Wl,--as-needed.

Checked on x86_64-linux-gnu.

2 years agoresolv: Move ns_name_unpack to its own file and into libc
Florian Weimer [Thu, 15 Jul 2021 06:28:50 +0000 (08:28 +0200)] 
resolv: Move ns_name_unpack to its own file and into libc

Reformat to GNU style. Avoid out-of-bounds buffer arithmetic.
Eliminate the labellen function.

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Remove unnecessary res_isourserver_p call from send_dg
Florian Weimer [Thu, 15 Jul 2021 06:28:51 +0000 (08:28 +0200)] 
resolv: Remove unnecessary res_isourserver_p call from send_dg

As the comment indicates, the check is unnecessary due to the way the
UDP socket is set up.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Move ns_name_ntop to its own file and into libc
Florian Weimer [Thu, 15 Jul 2021 06:28:50 +0000 (08:28 +0200)] 
resolv: Move ns_name_ntop to its own file and into libc

Reformat to GNU style.  Avoid out-of-bounds pointer arithmetic
(e.g., use eom - dn < 2 instead of dn + 1 >= eom).  Inline the
labellen function and fold the compression pointer check into
the length check (l >= 64).  Assume ASCII encoding.

The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agonss_dns: Do not use deprecated packet parsing functions
Florian Weimer [Thu, 15 Jul 2021 06:28:50 +0000 (08:28 +0200)] 
nss_dns: Do not use deprecated packet parsing functions

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoresolv: Sort Makefile routines and Versions lexicographically
Florian Weimer [Thu, 15 Jul 2021 06:28:50 +0000 (08:28 +0200)] 
resolv: Sort Makefile routines and Versions lexicographically

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agosocket: Add hidden prototype for setsockopt
Florian Weimer [Thu, 15 Jul 2021 06:28:50 +0000 (08:28 +0200)] 
socket: Add hidden prototype for setsockopt

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
2 years agoelf: Fix DTV gap reuse logic (BZ #27135)
Adhemerval Zanella [Fri, 25 Jun 2021 13:54:12 +0000 (10:54 -0300)] 
elf: Fix DTV gap reuse logic (BZ #27135)

This is updated version of the 572bd547d57a (reverted by 40ebfd016ad2)
that fixes the _dl_next_tls_modid issues.

This issue with 572bd547d57a patch is the DTV entry will be only
update on dl_open_worker() with the update_tls_slotinfo() call after
all dependencies are being processed by _dl_map_object_deps().  However
_dl_map_object_deps() itself might call _dl_next_tls_modid(), and since
the _dl_tls_dtv_slotinfo_list::map is not yet set the entry will be
wrongly reused.

This patch fixes by renaming the _dl_next_tls_modid() function to
_dl_assign_tls_modid() and by passing the link_map so it can set
the slotinfo value so a subsequente _dl_next_tls_modid() call will
see the entry as allocated.

The intermediary value is cleared up on remove_slotinfo() for the case
a library fails to load with RTLD_NOW.

This patch fixes BZ #27135.

Checked on x86_64-linux-gnu.

Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
2 years agoFix linknamespace errors and local-plt-usages in nss_files.
Stefan Liebler [Wed, 14 Jul 2021 13:58:08 +0000 (15:58 +0200)] 
Fix linknamespace errors and local-plt-usages in nss_files.

After commit f9c8b11ed7726b858cd7b7cea0d3d7c5233d78cf
"nss: Access nss_files through direct references",
when building with -Os, multiple conform/.../linknamespace tests
and elf/check-localplt are failing:
Extra PLT reference: libc.so: fgetc_unlocked
Extra PLT reference: libc.so: getline

Or e.g.:
[initial] glob -> [libc.a(glob.o)] __getpwnam_r -> [libc.a(getpwnam_r.o)] __nss_database_custom -> [libc.a(nsswitch.o)] __nss_module_get_function -> [libc.a(nss_module.o)] __nss_files_functions -> [libc.a(nss_files_functions.o)] _nss_files_endaliasent -> [libc.a(files-alias.o)] feof_unlocked
[initial] glob -> [libc.a(glob.o)] __getpwnam_r -> [libc.a(getpwnam_r.o)] __nss_database_custom -> [libc.a(nsswitch.o)] __nss_module_get_function -> [libc.a(nss_module.o)] __nss_files_functions -> [libc.a(nss_files_functions.o)] _nss_files_endaliasent -> [libc.a(files-alias.o)] fgetc_unlocked
[initial] glob -> [libc.a(glob.o)] __getpwnam_r -> [libc.a(getpwnam_r.o)] __nss_database_custom -> [libc.a(nsswitch.o)] __nss_module_get_function -> [libc.a(nss_module.o)] __nss_files_functions -> [libc.a(nss_files_functions.o)] _nss_files_endnetgrent -> [libc.a(files-netgrp.o)] getline

This patch is using the hidden symbols where possible.
Instead of fputc_unlocked, __putc_unlocked is used.
(Compare to commit eeaa19f75e52d2d48074ae0c423f2311d67c42c6
"mntent: Use __putc_unlocked instead of fputc_unlocked")

2 years agoAdd static tests for __clone_internal
H.J. Lu [Fri, 14 May 2021 22:23:46 +0000 (15:23 -0700)] 
Add static tests for __clone_internal

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agox86-64: Add the clone3 wrapper
H.J. Lu [Thu, 13 May 2021 15:24:36 +0000 (08:24 -0700)] 
x86-64: Add the clone3 wrapper

extern int clone3 (struct clone_args *__cl_args, size_t __size,
   int (*__func) (void *__arg), void *__arg);

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agoAdd an internal wrapper for clone, clone2 and clone3
H.J. Lu [Sat, 13 Feb 2021 19:47:46 +0000 (11:47 -0800)] 
Add an internal wrapper for clone, clone2 and clone3

The clone3 system call (since Linux 5.3) provides a superset of the
functionality of clone and clone2.  It also provides a number of API
improvements, including the ability to specify the size of the child's
stack area which can be used by kernel to compute the shadow stack size
when allocating the shadow stack.  Add:

extern int __clone_internal (struct clone_args *__cl_args,
     int (*__func) (void *__arg), void *__arg);

to provide an abstract interface for clone, clone2 and clone3.

1. Simplify stack management for thread creation by passing both stack
base and size to create_thread.
2. Consolidate clone vs clone2 differences into a single file.
3. Call __clone3 if HAVE_CLONE3_WAPPER is defined.  If __clone3 returns
-1 with ENOSYS, fall back to clone or clone2.
4. Use only __clone_internal to clone a thread.  Since the stack size
argument for create_thread is now unconditional, always pass stack size
to create_thread.
5. Enable the public clone3 wrapper in the future after it has been
added to all targets.

NB: Sandbox will return ENOSYS on clone3 in both Chromium:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/218438259dd795456f0a48f67cbe5b4e520db88b

commit 218438259dd795456f0a48f67cbe5b4e520db88b
Author: Matthew Denton <mpdenton@chromium.org>
Date: Thu Jun 03 20:06:13 2021

Linux sandbox: return ENOSYS for clone3

Because clone3 uses a pointer argument rather than a flags argument, we
cannot examine the contents with seccomp, which is essential to
preventing sandboxed processes from starting other processes. So, we
won't be able to support clone3 in Chromium. This CL modifies the
BPF policy to return ENOSYS for clone3 so glibc always uses the fallback
to clone.

Bug: 1213452
Change-Id: I7c7c585a319e0264eac5b1ebee1a45be2d782303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2936184
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#888980}

[modify] https://crrev.com/218438259dd795456f0a48f67cbe5b4e520db88b/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc

and Firefox:

https://hg.mozilla.org/integration/autoland/rev/ecb4011a0c76

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 years agonss: Fix build error with --disable-nscd
Cooper Qu [Tue, 13 Jul 2021 12:50:40 +0000 (20:50 +0800)] 
nss: Fix build error with --disable-nscd

The error is as follows:
nss_module.c: In function 'module_load_nss_files':
nss_module.c:117:7: error: 'is_nscd' undeclared (first use in this function)
  117 |   if (is_nscd)
      |       ^~~~~~~
nss_module.c:117:7: note: each undeclared identifier is reported only once for each function it appears in
nss_module.c:119:51: error: 'nscd_init_cb' undeclared (first use in this function); did you mean 'nscd_init'?
  119 |       void (*cb) (size_t, struct traced_file *) = nscd_init_cb;
      |                                                   ^~~~~~~~~~~~
      |                                                   nscd_init

2 years agohtl: Fix linking static examples against libpthread
Samuel Thibault [Tue, 13 Jul 2021 21:45:57 +0000 (21:45 +0000)] 
htl: Fix linking static examples against libpthread

libpthread.a uses some mach and hurd RPCs so we need to link them in.

2 years agohtl: Let libc call __pthread_mutex_{,try,un}lock
Samuel Thibault [Tue, 13 Jul 2021 21:33:39 +0000 (21:33 +0000)] 
htl: Let libc call __pthread_mutex_{,try,un}lock

Now that NPTL was moved to libc, libc makes internal __pthread calls, so
htl has to expose them internally.

2 years agoposix: Ignore non opened files on tst-spawn5
Adhemerval Zanella [Tue, 13 Jul 2021 13:46:23 +0000 (10:46 -0300)] 
posix: Ignore non opened files on tst-spawn5

The make program  might open a pipe for its job server, which triggers
an invalid check on the spawned process.  This patch now passes the
lowest file descriptor as ithe first argument, so only the range
that was actually opened is checked.

Checked on x86_64-linux-gnu and i686-linux-gnu and centos7 (which
triggers the issue).

2 years agomcheck: Align struct hdr to MALLOC_ALIGNMENT bytes [BZ #28068]
H.J. Lu [Mon, 12 Jul 2021 21:36:39 +0000 (14:36 -0700)] 
mcheck: Align struct hdr to MALLOC_ALIGNMENT bytes [BZ #28068]

1. Align struct hdr to MALLOC_ALIGNMENT bytes so that malloc hooks in
libmcheck align memory to MALLOC_ALIGNMENT bytes.
2. Remove tst-mallocalign1 from tests-exclude-mcheck for i386 and x32.
3. Add tst-pvalloc-fortify and tst-reallocarray to tests-exclude-mcheck
since they use malloc_usable_size (see BZ #22057).

This fixed BZ #28068.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
2 years agoLinux: Use 32-bit vDSO for clock_gettime, gettimeofday, time (BZ# 28071)
Adhemerval Zanella [Sat, 10 Jul 2021 20:03:49 +0000 (17:03 -0300)] 
Linux: Use 32-bit vDSO for clock_gettime, gettimeofday, time (BZ# 28071)

The previous approach defeats the vDSO optimization on older kernels
because a failing clock_gettime64 system call is performed on every
function call.  It also results in a clobbered errno value, exposing
an OpenJDK bug (JDK-8270244).

This patch fixes by open-code INLINE_VSYSCALL macro and replace all
INLINE_SYSCALL_CALL with INTERNAL_SYSCALL_CALLS.  Now for
__clock_gettime64x, the 64-bit vDSO is used and the 32-bit vDSO is
tried before falling back to 64-bit syscalls.

The previous code preferred 64-bit syscall for the case where the kernel
provides 64-bit time_t syscalls *and* also a 32-bit vDSO (in this case
the *64-bit* syscall should be preferable over the vDSO).  All
architectures that provides 32-bit vDSO (i386, mips, powerpc, s390)
modulo sparc; but I am not sure if some kernels versions do provide
only 32-bit vDSO while still providing 64-bit time_t syscall.
Regardless, for such cases the 64-bit time_t syscall is used if the
vDSO returns overflowed 32-bit time_t.

Tested on i686-linux-gnu (with a time64 and non-time64 kernel),
x86_64-linux-gnu.  Built with build-many-glibcs.py.

Co-authored-by: Florian Weimer <fweimer@redhat.com>
2 years agoReduce <limits.h> pollution due to dynamic PTHREAD_STACK_MIN
Florian Weimer [Mon, 12 Jul 2021 16:43:32 +0000 (18:43 +0200)] 
Reduce <limits.h> pollution due to dynamic PTHREAD_STACK_MIN

<limits.h> used to be a header file with no declarations.
GCC's libgomp includes it in a #pragma GCC visibility hidden block.
Including <unistd.h> from <limits.h> (indirectly) declares everything
in <unistd.h> with hidden visibility, resulting in linker failures.

This commit avoids C declarations in assembler mode and only declares
__sysconf in <limits.h> (and not the entire contents of <unistd.h>).
The __sysconf symbol is already part of the ABI.  PTHREAD_STACK_MIN
is no longer defined for __USE_DYNAMIC_STACK_SIZE && __ASSEMBLER__
because there is no possible definition.

Additionally, PTHREAD_STACK_MIN is now defined by <pthread.h> for
__USE_MISC because this is what developers expect based on the macro
name.  It also helps to avoid libgomp linker failures in GCC because
libgomp includes <pthread.h> before its visibility hacks.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agoFix failing nss/tst-nss-files-hosts-long.
Stefan Liebler [Mon, 12 Jul 2021 09:00:53 +0000 (11:00 +0200)] 
Fix failing nss/tst-nss-files-hosts-long.

Sometimes the test nss/tst-nss-files-hosts-long is failing as getent
fails with exit-code 2.

This happens if tst-reload1 was run just before this test:
make t=nss/tst-reload1 test
make t=nss/tst-nss-files-hosts-long test
Then the test fails as /etc/nsswitch.conf contains "hosts: test2"
and the hosts are not searched in /etc/hosts at all.

Thus this patch just requests a post cleanup after nss/tst-reload1
has run.

2 years agonis: nis_local_group may read from __nisgroup[-1] (bug 28075)
Florian Weimer [Mon, 12 Jul 2021 05:58:07 +0000 (07:58 +0200)] 
nis: nis_local_group may read from __nisgroup[-1] (bug 28075)

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
2 years agohurd _Fork: Drop duplicate malloc_fork_lock calls
Samuel Thibault [Sun, 11 Jul 2021 17:51:12 +0000 (17:51 +0000)] 
hurd _Fork: Drop duplicate malloc_fork_lock calls

This was put in __libc_fork by c32c868ab8b2 ("posix: Add _Fork [BZ #4737]")
so we need to avoid locking them again in _Fork called by __libc_lock, otherwise
we deadlock.