]> git.ipfire.org Git - thirdparty/glibc.git/commit
RISC-V: Fix elfutils testsuite unwind failures.
authorJim Wilson <jimw@sifive.com>
Sun, 13 Jan 2019 23:48:09 +0000 (15:48 -0800)
committerPalmer Dabbelt <palmer@sifive.com>
Wed, 13 Feb 2019 22:25:00 +0000 (14:25 -0800)
commit85bd1ddbdfdfd13cfd06f7c367519b6ed3360843
treeb129acc357887fb5345ff240d4521ddb862630bf
parent107562682c8f6a5736a0a8257428c15a3c68a165
RISC-V: Fix elfutils testsuite unwind failures.

The clone.S patch fixes 2 elfutils testsuite unwind failures, where the
backtrace gets stuck repeating __thread_start until we hit the backtrace
limit.  This was confirmed by building and installing a patched glibc and
then building elfutils and running its testsuite.

Unfortunately, the testcase isn't working as expected and I don't know why.
The testcase passes even when my clone.S patch is not installed.  The testcase
looks logically similarly to the elfutils testcases that are failing.  Maybe
there is a subtle difference in how the glibc unwinding works versus the
elfutils unwinding?  I don't have good gdb pthread support yet, so I haven't
found a way to debug this.  Anyways, I don't know if the testcase is useful or
not.  If the testcase isn't useful then maybe the clone.S patch is OK without
a testcase?

Jim

[BZ #24040]
* elf/Makefile (CFLAGS-tst-unwind-main.c): Add -DUSE_PTHREADS=0.
* elf/tst-unwind-main.c: If USE_PTHEADS, include pthread.h and error.h
(func): New.
(main): If USE_PTHREADS, call pthread_create to run func.  Otherwise
call func directly.
* nptl/Makefile (tests): Add tst-unwind-thread.
(CFLAGS-tst-unwind-thread.c): Define.
* nptl/tst-unwind-thread.c: New file.
* sysdeps/unix/sysv/linux/riscv/clone.S (__thread_start): Mark ra
as undefined.
ChangeLog
elf/Makefile
elf/tst-unwind-main.c
nptl/Makefile
nptl/tst-unwind-thread.c [new file with mode: 0644]
sysdeps/unix/sysv/linux/riscv/clone.S