]> git.ipfire.org Git - thirdparty/hostap.git/blobdiff - tests/hwsim/test_ap_ft.py
tests: Fix ap_ft_reassoc_replay for case where wlantest has the PSK
[thirdparty/hostap.git] / tests / hwsim / test_ap_ft.py
index f77c407ab3126b8c86040f4b30ccc67d3f761e7a..1556158292e1b47e4b5ba6f4afdd2c5eefe41fd8 100644 (file)
@@ -22,18 +22,19 @@ from utils import HwsimSkip, alloc_fail, fail_test, wait_fail_trigger, skip_with
 from wlantest import Wlantest
 from test_ap_psk import check_mib, find_wpas_process, read_process_memory, verify_not_present, get_key_locations
 from test_rrm import check_beacon_req
+from test_suite_b import check_suite_b_192_capa
 
 def ft_base_rsn():
-    params = { "wpa": "2",
-               "wpa_key_mgmt": "FT-PSK",
-               "rsn_pairwise": "CCMP" }
+    params = {"wpa": "2",
+              "wpa_key_mgmt": "FT-PSK",
+              "rsn_pairwise": "CCMP"}
     return params
 
 def ft_base_mixed():
-    params = { "wpa": "3",
-               "wpa_key_mgmt": "WPA-PSK FT-PSK",
-               "wpa_pairwise": "TKIP",
-               "rsn_pairwise": "CCMP" }
+    params = {"wpa": "3",
+              "wpa_key_mgmt": "WPA-PSK FT-PSK",
+              "wpa_pairwise": "TKIP",
+              "rsn_pairwise": "CCMP"}
     return params
 
 def ft_params(rsn=True, ssid=None, passphrase=None):
@@ -64,15 +65,15 @@ def ft_params1(rsn=True, ssid=None, passphrase=None, discovery=False):
         params['r0kh'] = "ff:ff:ff:ff:ff:ff * 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f"
         params['r1kh'] = "00:00:00:00:00:00 00:00:00:00:00:00 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f"
     else:
-        params['r0kh'] = [ "02:00:00:00:03:00 nas1.w1.fi 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f",
-                           "02:00:00:00:04:00 nas2.w1.fi 300102030405060708090a0b0c0d0e0f300102030405060708090a0b0c0d0e0f" ]
+        params['r0kh'] = ["02:00:00:00:03:00 nas1.w1.fi 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f",
+                          "02:00:00:00:04:00 nas2.w1.fi 300102030405060708090a0b0c0d0e0f300102030405060708090a0b0c0d0e0f"]
         params['r1kh'] = "02:00:00:00:04:00 00:01:02:03:04:06 200102030405060708090a0b0c0d0e0f200102030405060708090a0b0c0d0e0f"
     return params
 
 def ft_params1_old_key(rsn=True, ssid=None, passphrase=None):
     params = ft_params1a(rsn, ssid, passphrase)
-    params['r0kh'] = [ "02:00:00:00:03:00 nas1.w1.fi 100102030405060708090a0b0c0d0e0f",
-                       "02:00:00:00:04:00 nas2.w1.fi 300102030405060708090a0b0c0d0e0f" ]
+    params['r0kh'] = ["02:00:00:00:03:00 nas1.w1.fi 100102030405060708090a0b0c0d0e0f",
+                      "02:00:00:00:04:00 nas2.w1.fi 300102030405060708090a0b0c0d0e0f"]
     params['r1kh'] = "02:00:00:00:04:00 00:01:02:03:04:06 200102030405060708090a0b0c0d0e0f"
     return params
 
@@ -88,15 +89,15 @@ def ft_params2(rsn=True, ssid=None, passphrase=None, discovery=False):
         params['r0kh'] = "ff:ff:ff:ff:ff:ff * 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f"
         params['r1kh'] = "00:00:00:00:00:00 00:00:00:00:00:00 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f"
     else:
-        params['r0kh'] = [ "02:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0e0f200102030405060708090a0b0c0d0e0f",
-                           "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0e0f000102030405060708090a0b0c0d0e0f" ]
+        params['r0kh'] = ["02:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0e0f200102030405060708090a0b0c0d0e0f",
+                          "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0e0f000102030405060708090a0b0c0d0e0f"]
         params['r1kh'] = "02:00:00:00:03:00 00:01:02:03:04:05 300102030405060708090a0b0c0d0e0f300102030405060708090a0b0c0d0e0f"
     return params
 
 def ft_params2_old_key(rsn=True, ssid=None, passphrase=None):
     params = ft_params2a(rsn, ssid, passphrase)
-    params['r0kh'] = [ "02:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0e0f",
-                       "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0e0f" ]
+    params['r0kh'] = ["02:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0e0f",
+                      "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0e0f"]
     params['r1kh'] = "02:00:00:00:03:00 00:01:02:03:04:05 300102030405060708090a0b0c0d0e0f"
     return params
 
@@ -104,8 +105,8 @@ def ft_params1_r0kh_mismatch(rsn=True, ssid=None, passphrase=None):
     params = ft_params(rsn, ssid, passphrase)
     params['nas_identifier'] = "nas1.w1.fi"
     params['r1_key_holder'] = "000102030405"
-    params['r0kh'] = [ "02:00:00:00:03:00 nas1.w1.fi 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f",
-                       "12:00:00:00:04:00 nas2.w1.fi 300102030405060708090a0b0c0d0e0f300102030405060708090a0b0c0d0e0f" ]
+    params['r0kh'] = ["02:00:00:00:03:00 nas1.w1.fi 100102030405060708090a0b0c0d0e0f100102030405060708090a0b0c0d0e0f",
+                      "12:00:00:00:04:00 nas2.w1.fi 300102030405060708090a0b0c0d0e0f300102030405060708090a0b0c0d0e0f"]
     params['r1kh'] = "12:00:00:00:04:00 10:01:02:03:04:06 200102030405060708090a0b0c0d0e0f200102030405060708090a0b0c0d0e0f"
     return params
 
@@ -113,8 +114,8 @@ def ft_params2_incorrect_rrb_key(rsn=True, ssid=None, passphrase=None):
     params = ft_params(rsn, ssid, passphrase)
     params['nas_identifier'] = "nas2.w1.fi"
     params['r1_key_holder'] = "000102030406"
-    params['r0kh'] = [ "02:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0ef1200102030405060708090a0b0c0d0ef1",
-                       "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0ef2000102030405060708090a0b0c0d0ef2" ]
+    params['r0kh'] = ["02:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0ef1200102030405060708090a0b0c0d0ef1",
+                      "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0ef2000102030405060708090a0b0c0d0ef2"]
     params['r1kh'] = "02:00:00:00:03:00 00:01:02:03:04:05 300102030405060708090a0b0c0d0ef3300102030405060708090a0b0c0d0ef3"
     return params
 
@@ -122,8 +123,8 @@ def ft_params2_r0kh_mismatch(rsn=True, ssid=None, passphrase=None):
     params = ft_params(rsn, ssid, passphrase)
     params['nas_identifier'] = "nas2.w1.fi"
     params['r1_key_holder'] = "000102030406"
-    params['r0kh'] = [ "12:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0e0f200102030405060708090a0b0c0d0e0f",
-                       "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0e0f000102030405060708090a0b0c0d0e0f" ]
+    params['r0kh'] = ["12:00:00:00:03:00 nas1.w1.fi 200102030405060708090a0b0c0d0e0f200102030405060708090a0b0c0d0e0f",
+                      "02:00:00:00:04:00 nas2.w1.fi 000102030405060708090a0b0c0d0e0f000102030405060708090a0b0c0d0e0f"]
     params['r1kh'] = "12:00:00:00:03:00 10:01:02:03:04:05 300102030405060708090a0b0c0d0e0f300102030405060708090a0b0c0d0e0f"
     return params
 
@@ -133,28 +134,35 @@ def run_roams(dev, apdev, hapd0, hapd1, ssid, passphrase, over_ds=False,
               test_connectivity=True, eap_identity="gpsk user", conndev=False,
               force_initial_conn_to_first_ap=False, sha384=False,
               group_mgmt=None, ocv=None, sae_password=None,
-              sae_password_id=None):
+              sae_password_id=None, sae_and_psk=False, pmksa_caching=False,
+              roam_with_reassoc=False, also_non_ft=False, only_one_way=False,
+              wait_before_roam=0, return_after_initial=False, ieee80211w="1"):
     logger.info("Connect to first AP")
 
     copts = {}
     copts["proto"] = "WPA2"
-    copts["ieee80211w"] = "1"
+    copts["ieee80211w"] = ieee80211w
     copts["scan_freq"] = "2412"
     copts["pairwise"] = pairwise_cipher
-    copts["group"]  = group_cipher
+    copts["group"] = group_cipher
     copts["wpa_ptk_rekey"] = ptk_rekey
     if group_mgmt:
         copts["group_mgmt"] = group_mgmt
     if ocv:
         copts["ocv"] = ocv
     if eap:
-        copts["key_mgmt"] = "FT-EAP-SHA384" if sha384 else "FT-EAP"
+        if pmksa_caching:
+            copts["ft_eap_pmksa_caching"] = "1"
+        if also_non_ft:
+            copts["key_mgmt"] = "WPA-EAP-SUITE-B-192 FT-EAP-SHA384" if sha384 else "WPA-EAP FT-EAP"
+        else:
+            copts["key_mgmt"] = "FT-EAP-SHA384" if sha384 else "FT-EAP"
         copts["eap"] = "GPSK"
         copts["identity"] = eap_identity
         copts["password"] = "abcdefghijklmnop0123456789abcdef"
     else:
         if sae:
-            copts["key_mgmt"] = "FT-SAE"
+            copts["key_mgmt"] = "SAE FT-SAE" if sae_and_psk else "FT-SAE"
         else:
             copts["key_mgmt"] = "FT-PSK"
         if passphrase:
@@ -165,7 +173,21 @@ def run_roams(dev, apdev, hapd0, hapd1, ssid, passphrase, over_ds=False,
             copts["sae_password_id"] = sae_password_id
     if force_initial_conn_to_first_ap:
         copts["bssid"] = apdev[0]['bssid']
-    dev.connect(ssid, **copts)
+    netw = dev.connect(ssid, **copts)
+    if pmksa_caching:
+        dev.request("DISCONNECT")
+        dev.wait_disconnected()
+        dev.request("RECONNECT")
+        ev = dev.wait_event(["CTRL-EVENT-CONNECTED",
+                             "CTRL-EVENT-DISCONNECTED",
+                             "CTRL-EVENT-EAP-STARTED"],
+                            timeout=15)
+        if ev is None:
+            raise Exception("Reconnect timed out")
+        if "CTRL-EVENT-DISCONNECTED" in ev:
+            raise Exception("Unexpected disconnection after RECONNECT")
+        if "CTRL-EVENT-EAP-STARTED" in ev:
+            raise Exception("Unexpected EAP start after RECONNECT")
 
     if dev.get_status_field('bssid') == apdev[0]['bssid']:
         ap1 = apdev[0]
@@ -178,11 +200,17 @@ def run_roams(dev, apdev, hapd0, hapd1, ssid, passphrase, over_ds=False,
         hapd1ap = hapd1
         hapd2ap = hapd0
     if test_connectivity:
+        hapd1ap.wait_sta()
         if conndev:
             hwsim_utils.test_connectivity_iface(dev, hapd1ap, conndev)
         else:
             hwsim_utils.test_connectivity(dev, hapd1ap)
 
+    if return_after_initial:
+        return ap2['bssid']
+
+    if wait_before_roam:
+        time.sleep(wait_before_roam)
     dev.scan_for_bss(ap2['bssid'], freq="2412")
 
     for i in range(0, roams):
@@ -190,7 +218,11 @@ def run_roams(dev, apdev, hapd0, hapd1, ssid, passphrase, over_ds=False,
         # set later.
         time.sleep(0.01)
         logger.info("Roam to the second AP")
-        if over_ds:
+        if roam_with_reassoc:
+            dev.set_network(netw, "bssid", ap2['bssid'])
+            dev.request("REASSOCIATE")
+            dev.wait_connected()
+        elif over_ds:
             dev.roam_over_ds(ap2['bssid'], fail_test=fail_test)
         else:
             dev.roam(ap2['bssid'], fail_test=fail_test)
@@ -199,22 +231,30 @@ def run_roams(dev, apdev, hapd0, hapd1, ssid, passphrase, over_ds=False,
         if dev.get_status_field('bssid') != ap2['bssid']:
             raise Exception("Did not connect to correct AP")
         if (i == 0 or i == roams - 1) and test_connectivity:
+            hapd2ap.wait_sta()
             if conndev:
                 hwsim_utils.test_connectivity_iface(dev, hapd2ap, conndev)
             else:
                 hwsim_utils.test_connectivity(dev, hapd2ap)
 
+        if only_one_way:
+            return
         # Roaming artificially fast can make data test fail because the key is
         # set later.
         time.sleep(0.01)
         logger.info("Roam back to the first AP")
-        if over_ds:
+        if roam_with_reassoc:
+            dev.set_network(netw, "bssid", ap1['bssid'])
+            dev.request("REASSOCIATE")
+            dev.wait_connected()
+        elif over_ds:
             dev.roam_over_ds(ap1['bssid'])
         else:
             dev.roam(ap1['bssid'])
         if dev.get_status_field('bssid') != ap1['bssid']:
             raise Exception("Did not connect to correct AP")
         if (i == 0 or i == roams - 1) and test_connectivity:
+            hapd1ap.wait_sta()
             if conndev:
                 hwsim_utils.test_connectivity_iface(dev, hapd1ap, conndev)
             else:
@@ -223,7 +263,7 @@ def run_roams(dev, apdev, hapd0, hapd1, ssid, passphrase, over_ds=False,
 def test_ap_ft(dev, apdev):
     """WPA2-PSK-FT AP"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -237,7 +277,7 @@ def test_ap_ft(dev, apdev):
 def test_ap_ft_old_key(dev, apdev):
     """WPA2-PSK-FT AP (old key)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1_old_key(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -249,7 +289,7 @@ def test_ap_ft_old_key(dev, apdev):
 def test_ap_ft_multi_akm(dev, apdev):
     """WPA2-PSK-FT AP with non-FT AKMs enabled"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["wpa_key_mgmt"] = "FT-PSK WPA-PSK WPA-PSK-SHA256"
@@ -273,7 +313,7 @@ def test_ap_ft_multi_akm(dev, apdev):
 def test_ap_ft_local_key_gen(dev, apdev):
     """WPA2-PSK-FT AP with local key generation (without pull/push)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1a(ssid=ssid, passphrase=passphrase)
     params['ft_psk_generate_local'] = "1"
@@ -291,7 +331,7 @@ def test_ap_ft_local_key_gen(dev, apdev):
 def test_ap_ft_vlan(dev, apdev):
     """WPA2-PSK-FT AP with VLAN"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['dynamic_vlan'] = "1"
@@ -310,7 +350,7 @@ def test_ap_ft_vlan(dev, apdev):
 def test_ap_ft_vlan_disconnected(dev, apdev):
     """WPA2-PSK-FT AP with VLAN and local key generation"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1a(ssid=ssid, passphrase=passphrase)
     params['dynamic_vlan'] = "1"
@@ -331,7 +371,7 @@ def test_ap_ft_vlan_disconnected(dev, apdev):
 def test_ap_ft_vlan_2(dev, apdev):
     """WPA2-PSK-FT AP with VLAN and dest-AP does not have VLAN info locally"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['dynamic_vlan'] = "1"
@@ -350,7 +390,7 @@ def test_ap_ft_vlan_2(dev, apdev):
 def test_ap_ft_many(dev, apdev):
     """WPA2-PSK-FT AP multiple times"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -362,7 +402,7 @@ def test_ap_ft_many(dev, apdev):
 def test_ap_ft_many_vlan(dev, apdev):
     """WPA2-PSK-FT AP with VLAN multiple times"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['dynamic_vlan'] = "1"
@@ -380,7 +420,7 @@ def test_ap_ft_many_vlan(dev, apdev):
 def test_ap_ft_mixed(dev, apdev):
     """WPA2-PSK-FT mixed-mode AP"""
     ssid = "test-ft-mixed"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(rsn=False, ssid=ssid, passphrase=passphrase)
     hapd = hostapd.add_ap(apdev[0], params)
@@ -395,8 +435,23 @@ def test_ap_ft_mixed(dev, apdev):
 
 def test_ap_ft_pmf(dev, apdev):
     """WPA2-PSK-FT AP with PMF"""
+    run_ap_ft_pmf(dev, apdev, "1")
+
+def test_ap_ft_pmf_over_ds(dev, apdev):
+    """WPA2-PSK-FT AP with PMF (over DS)"""
+    run_ap_ft_pmf(dev, apdev, "1", over_ds=True)
+
+def test_ap_ft_pmf_required(dev, apdev):
+    """WPA2-PSK-FT AP with PMF required on STA"""
+    run_ap_ft_pmf(dev, apdev, "2")
+
+def test_ap_ft_pmf_required_over_ds(dev, apdev):
+    """WPA2-PSK-FT AP with PMF required on STA (over DS)"""
+    run_ap_ft_pmf(dev, apdev, "2", over_ds=True)
+
+def run_ap_ft_pmf(dev, apdev, ieee80211w, over_ds=False):
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -405,7 +460,36 @@ def test_ap_ft_pmf(dev, apdev):
     params["ieee80211w"] = "2"
     hapd1 = hostapd.add_ap(apdev[1], params)
 
-    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase)
+    Wlantest.setup(hapd0)
+    wt = Wlantest()
+    wt.flush()
+    wt.add_passphrase(passphrase)
+
+    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase,
+              ieee80211w=ieee80211w, over_ds=over_ds)
+
+def test_ap_ft_pmf_required_mismatch(dev, apdev):
+    """WPA2-PSK-FT AP with PMF required on STA but AP2 not enabling PMF"""
+    run_ap_ft_pmf_required_mismatch(dev, apdev)
+
+def test_ap_ft_pmf_required_mismatch_over_ds(dev, apdev):
+    """WPA2-PSK-FT AP with PMF required on STA but AP2 not enabling PMF (over DS)"""
+    run_ap_ft_pmf_required_mismatch(dev, apdev, over_ds=True)
+
+def run_ap_ft_pmf_required_mismatch(dev, apdev, over_ds=False):
+    ssid = "test-ft"
+    passphrase = "12345678"
+
+    params = ft_params1(ssid=ssid, passphrase=passphrase)
+    params["ieee80211w"] = "2"
+    hapd0 = hostapd.add_ap(apdev[0], params)
+    params = ft_params2(ssid=ssid, passphrase=passphrase)
+    params["ieee80211w"] = "0"
+    hapd1 = hostapd.add_ap(apdev[1], params)
+
+    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, ieee80211w="2",
+              force_initial_conn_to_first_ap=True, fail_test=True,
+              over_ds=over_ds)
 
 def test_ap_ft_pmf_bip_cmac_128(dev, apdev):
     """WPA2-PSK-FT AP with PMF/BIP-CMAC-128"""
@@ -428,7 +512,7 @@ def run_ap_ft_pmf_bip(dev, apdev, cipher):
         raise HwsimSkip("Cipher %s not supported" % cipher)
 
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -445,7 +529,7 @@ def run_ap_ft_pmf_bip(dev, apdev, cipher):
 def test_ap_ft_ocv(dev, apdev):
     """WPA2-PSK-FT AP with OCV"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -466,7 +550,7 @@ def test_ap_ft_ocv(dev, apdev):
 def test_ap_ft_over_ds(dev, apdev):
     """WPA2-PSK-FT AP over DS"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -474,8 +558,8 @@ def test_ap_ft_over_ds(dev, apdev):
     hapd1 = hostapd.add_ap(apdev[1], params)
 
     run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, over_ds=True)
-    check_mib(dev[0], [ ("dot11RSNAAuthenticationSuiteRequested", "00-0f-ac-4"),
-                        ("dot11RSNAAuthenticationSuiteSelected", "00-0f-ac-4") ])
+    check_mib(dev[0], [("dot11RSNAAuthenticationSuiteRequested", "00-0f-ac-4"),
+                       ("dot11RSNAAuthenticationSuiteSelected", "00-0f-ac-4")])
 
 def cleanup_ap_ft_separate_hostapd():
     subprocess.call(["brctl", "delif", "br0ft", "veth0"],
@@ -486,7 +570,7 @@ def cleanup_ap_ft_separate_hostapd():
                     stderr=open('/dev/null', 'w'))
     subprocess.call(["ip", "link", "del", "veth1"],
                     stderr=open('/dev/null', 'w'))
-    for ifname in [ 'br0ft', 'br1ft', 'br-ft' ]:
+    for ifname in ['br0ft', 'br1ft', 'br-ft']:
         subprocess.call(['ip', 'link', 'set', 'dev', ifname, 'down'],
                         stderr=open('/dev/null', 'w'))
         subprocess.call(['brctl', 'delbr', ifname],
@@ -508,7 +592,7 @@ def test_ap_ft_over_ds_separate_hostapd(dev, apdev, params):
 
 def run_ap_ft_separate_hostapd(dev, apdev, params, over_ds):
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
     logdir = params['logdir']
     pidfile = os.path.join(logdir, 'ap_ft_over_ds_separate_hostapd.pid')
     logfile = os.path.join(logdir, 'ap_ft_over_ds_separate_hostapd.hapd')
@@ -520,10 +604,10 @@ def run_ap_ft_separate_hostapd(dev, apdev, params, over_ds):
         subprocess.check_call(['brctl', 'setfd', br_ifname, '0'])
         subprocess.check_call(['ip', 'link', 'set', 'dev', br_ifname, 'up'])
 
-        subprocess.check_call([ "ip", "link", "add", "veth0", "type", "veth",
-                                "peer", "name", "veth0br" ])
-        subprocess.check_call([ "ip", "link", "add", "veth1", "type", "veth",
-                                "peer", "name", "veth1br" ])
+        subprocess.check_call(["ip", "link", "add", "veth0", "type", "veth",
+                               "peer", "name", "veth0br"])
+        subprocess.check_call(["ip", "link", "add", "veth1", "type", "veth",
+                               "peer", "name", "veth1br"])
         subprocess.check_call(['ip', 'link', 'set', 'dev', 'veth0br', 'up'])
         subprocess.check_call(['ip', 'link', 'set', 'dev', 'veth1br', 'up'])
         subprocess.check_call(['brctl', 'addif', br_ifname, 'veth0br'])
@@ -546,13 +630,13 @@ def run_ap_ft_separate_hostapd(dev, apdev, params, over_ds):
         prg = os.path.join(logdir, 'alt-hostapd/hostapd/hostapd')
         if not os.path.exists(prg):
             prg = '../../hostapd/hostapd'
-        cmd = [ prg, '-B', '-ddKt',
-                '-P', pidfile, '-f', logfile, '-g', global_ctrl ]
+        cmd = [prg, '-B', '-ddKt',
+               '-P', pidfile, '-f', logfile, '-g', global_ctrl]
         subprocess.check_call(cmd)
 
         hglobal = hostapd.HostapdGlobal(global_ctrl_override=global_ctrl)
-        apdev_ft = { 'ifname': iface }
-        apdev2 = [ apdev_ft, apdev[1] ]
+        apdev_ft = {'ifname': iface}
+        apdev2 = [apdev_ft, apdev[1]]
 
         params = ft_params1(ssid=ssid, passphrase=passphrase)
         params["r0kh"] = "ff:ff:ff:ff:ff:ff * 00112233445566778899aabbccddeeff00112233445566778899aabbccddeeff"
@@ -581,7 +665,7 @@ def run_ap_ft_separate_hostapd(dev, apdev, params, over_ds):
 def test_ap_ft_over_ds_ocv(dev, apdev):
     """WPA2-PSK-FT AP over DS"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -603,7 +687,7 @@ def test_ap_ft_over_ds_ocv(dev, apdev):
 def test_ap_ft_over_ds_disabled(dev, apdev):
     """WPA2-PSK-FT AP over DS disabled"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['ft_over_ds'] = '0'
@@ -618,7 +702,7 @@ def test_ap_ft_over_ds_disabled(dev, apdev):
 def test_ap_ft_vlan_over_ds(dev, apdev):
     """WPA2-PSK-FT AP over DS with VLAN"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['dynamic_vlan'] = "1"
@@ -631,13 +715,13 @@ def test_ap_ft_vlan_over_ds(dev, apdev):
 
     run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, over_ds=True,
               conndev="brvlan1")
-    check_mib(dev[0], [ ("dot11RSNAAuthenticationSuiteRequested", "00-0f-ac-4"),
-                        ("dot11RSNAAuthenticationSuiteSelected", "00-0f-ac-4") ])
+    check_mib(dev[0], [("dot11RSNAAuthenticationSuiteRequested", "00-0f-ac-4"),
+                       ("dot11RSNAAuthenticationSuiteSelected", "00-0f-ac-4")])
 
 def test_ap_ft_over_ds_many(dev, apdev):
     """WPA2-PSK-FT AP over DS multiple times"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -650,7 +734,7 @@ def test_ap_ft_over_ds_many(dev, apdev):
 def test_ap_ft_vlan_over_ds_many(dev, apdev):
     """WPA2-PSK-FT AP over DS with VLAN multiple times"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['dynamic_vlan'] = "1"
@@ -668,7 +752,7 @@ def test_ap_ft_vlan_over_ds_many(dev, apdev):
 def test_ap_ft_over_ds_unknown_target(dev, apdev):
     """WPA2-PSK-FT AP"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -681,7 +765,7 @@ def test_ap_ft_over_ds_unknown_target(dev, apdev):
 def test_ap_ft_over_ds_unexpected(dev, apdev):
     """WPA2-PSK-FT AP over DS and unexpected response"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -803,7 +887,7 @@ def run_ap_ft_pmf_bip_over_ds(dev, apdev, cipher):
         raise HwsimSkip("Cipher %s not supported" % cipher)
 
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -816,13 +900,18 @@ def run_ap_ft_pmf_bip_over_ds(dev, apdev, cipher):
         params["group_mgmt_cipher"] = cipher
     hapd1 = hostapd.add_ap(apdev[1], params)
 
+    Wlantest.setup(hapd0)
+    wt = Wlantest()
+    wt.flush()
+    wt.add_passphrase(passphrase)
+
     run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, over_ds=True,
               group_mgmt=cipher)
 
 def test_ap_ft_over_ds_pull(dev, apdev):
     """WPA2-PSK-FT AP over DS (pull PMK)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["pmk_r1_push"] = "0"
@@ -836,7 +925,7 @@ def test_ap_ft_over_ds_pull(dev, apdev):
 def test_ap_ft_over_ds_pull_old_key(dev, apdev):
     """WPA2-PSK-FT AP over DS (pull PMK; old key)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1_old_key(ssid=ssid, passphrase=passphrase)
     params["pmk_r1_push"] = "0"
@@ -850,7 +939,7 @@ def test_ap_ft_over_ds_pull_old_key(dev, apdev):
 def test_ap_ft_over_ds_pull_vlan(dev, apdev):
     """WPA2-PSK-FT AP over DS (pull PMK) with VLAN"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["pmk_r1_push"] = "0"
@@ -866,44 +955,82 @@ def test_ap_ft_over_ds_pull_vlan(dev, apdev):
     run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, over_ds=True,
               conndev="brvlan1")
 
-def test_ap_ft_sae(dev, apdev):
-    """WPA2-PSK-FT-SAE AP"""
-    if "SAE" not in dev[0].get_capability("auth_alg"):
+def start_ft_sae(dev, apdev, wpa_ptk_rekey=None):
+    if "SAE" not in dev.get_capability("auth_alg"):
         raise HwsimSkip("SAE not supported")
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['wpa_key_mgmt'] = "FT-SAE"
+    if wpa_ptk_rekey:
+        params['wpa_ptk_rekey'] = str(wpa_ptk_rekey)
     hapd0 = hostapd.add_ap(apdev[0], params)
     params = ft_params2(ssid=ssid, passphrase=passphrase)
     params['wpa_key_mgmt'] = "FT-SAE"
-    hapd = hostapd.add_ap(apdev[1], params)
-    key_mgmt = hapd.get_config()['key_mgmt']
+    if wpa_ptk_rekey:
+        params['wpa_ptk_rekey'] = str(wpa_ptk_rekey)
+    hapd1 = hostapd.add_ap(apdev[1], params)
+    key_mgmt = hapd1.get_config()['key_mgmt']
     if key_mgmt.split(' ')[0] != "FT-SAE":
         raise Exception("Unexpected GET_CONFIG(key_mgmt): " + key_mgmt)
 
-    dev[0].request("SET sae_groups ")
-    run_roams(dev[0], apdev, hapd0, hapd, ssid, passphrase, sae=True)
+    dev.request("SET sae_groups ")
+    return hapd0, hapd1
+
+def test_ap_ft_sae(dev, apdev):
+    """WPA2-PSK-FT-SAE AP"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True)
+
+def test_ap_ft_sae_ptk_rekey0(dev, apdev):
+    """WPA2-PSK-FT-SAE AP and PTK rekey triggered by station"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
+              ptk_rekey="1", roams=0)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
+def test_ap_ft_sae_ptk_rekey1(dev, apdev):
+    """WPA2-PSK-FT-SAE AP and PTK rekey triggered by station"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
+              ptk_rekey="1", only_one_way=True)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
+def test_ap_ft_sae_ptk_rekey_ap(dev, apdev):
+    """WPA2-PSK-FT-SAE AP and PTK rekey triggered by AP"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev, wpa_ptk_rekey=2)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
+              only_one_way=True)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
 
 def test_ap_ft_sae_over_ds(dev, apdev):
     """WPA2-PSK-FT-SAE AP over DS"""
-    if "SAE" not in dev[0].get_capability("auth_alg"):
-        raise HwsimSkip("SAE not supported")
-    ssid = "test-ft"
-    passphrase="12345678"
-
-    params = ft_params1(ssid=ssid, passphrase=passphrase)
-    params['wpa_key_mgmt'] = "FT-SAE"
-    hapd0 = hostapd.add_ap(apdev[0], params)
-    params = ft_params2(ssid=ssid, passphrase=passphrase)
-    params['wpa_key_mgmt'] = "FT-SAE"
-    hapd1 = hostapd.add_ap(apdev[1], params)
-
-    dev[0].request("SET sae_groups ")
-    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, sae=True,
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
               over_ds=True)
 
+def test_ap_ft_sae_over_ds_ptk_rekey0(dev, apdev):
+    """WPA2-PSK-FT-SAE AP over DS and PTK rekey triggered by station"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
+              over_ds=True, ptk_rekey="1", roams=0)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
+def test_ap_ft_sae_over_ds_ptk_rekey1(dev, apdev):
+    """WPA2-PSK-FT-SAE AP over DS and PTK rekey triggered by station"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
+              over_ds=True, ptk_rekey="1", only_one_way=True)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
+def test_ap_ft_sae_over_ds_ptk_rekey_ap(dev, apdev):
+    """WPA2-PSK-FT-SAE AP over DS and PTK rekey triggered by AP"""
+    hapd0, hapd1 = start_ft_sae(dev[0], apdev, wpa_ptk_rekey=2)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", sae=True,
+              over_ds=True, only_one_way=True)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
 def test_ap_ft_sae_pw_id(dev, apdev):
     """FT-SAE with Password Identifier"""
     if "SAE" not in dev[0].get_capability("auth_alg"):
@@ -925,19 +1052,62 @@ def test_ap_ft_sae_pw_id(dev, apdev):
     run_roams(dev[0], apdev, hapd0, hapd, ssid, passphrase=None, sae=True,
               sae_password="secret", sae_password_id="pwid")
 
+def test_ap_ft_sae_with_both_akms(dev, apdev):
+    """SAE + FT-SAE configuration"""
+    if "SAE" not in dev[0].get_capability("auth_alg"):
+        raise HwsimSkip("SAE not supported")
+    ssid = "test-ft"
+    passphrase = "12345678"
+
+    params = ft_params1(ssid=ssid, passphrase=passphrase)
+    params['wpa_key_mgmt'] = "FT-SAE SAE"
+    hapd0 = hostapd.add_ap(apdev[0], params)
+    params = ft_params2(ssid=ssid, passphrase=passphrase)
+    params['wpa_key_mgmt'] = "FT-SAE SAE"
+    hapd = hostapd.add_ap(apdev[1], params)
+    key_mgmt = hapd.get_config()['key_mgmt']
+    if key_mgmt.split(' ')[0] != "FT-SAE":
+        raise Exception("Unexpected GET_CONFIG(key_mgmt): " + key_mgmt)
+
+    dev[0].request("SET sae_groups ")
+    run_roams(dev[0], apdev, hapd0, hapd, ssid, passphrase, sae=True,
+              sae_and_psk=True)
+
+def test_ap_ft_sae_pmksa_caching(dev, apdev):
+    """WPA2-FT-SAE AP and PMKSA caching for initial mobility domain association"""
+    if "SAE" not in dev[0].get_capability("auth_alg"):
+        raise HwsimSkip("SAE not supported")
+    ssid = "test-ft"
+    passphrase = "12345678"
+
+    params = ft_params1(ssid=ssid, passphrase=passphrase)
+    params['wpa_key_mgmt'] = "FT-SAE"
+    hapd0 = hostapd.add_ap(apdev[0], params)
+    params = ft_params2(ssid=ssid, passphrase=passphrase)
+    params['wpa_key_mgmt'] = "FT-SAE"
+    hapd = hostapd.add_ap(apdev[1], params)
+    key_mgmt = hapd.get_config()['key_mgmt']
+    if key_mgmt.split(' ')[0] != "FT-SAE":
+        raise Exception("Unexpected GET_CONFIG(key_mgmt): " + key_mgmt)
+
+    dev[0].request("SET sae_groups ")
+    run_roams(dev[0], apdev, hapd0, hapd, ssid, passphrase, sae=True,
+              pmksa_caching=True)
+
 def generic_ap_ft_eap(dev, apdev, vlan=False, cui=False, over_ds=False,
-                      discovery=False, roams=1):
+                      discovery=False, roams=1, wpa_ptk_rekey=0,
+                      only_one_way=False):
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
     if vlan:
-        identity="gpsk-vlan1"
-        conndev="brvlan1"
+        identity = "gpsk-vlan1"
+        conndev = "brvlan1"
     elif cui:
-        identity="gpsk-cui"
-        conndev=False
+        identity = "gpsk-cui"
+        conndev = False
     else:
-        identity="gpsk user"
-        conndev=False
+        identity = "gpsk user"
+        conndev = False
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase, discovery=discovery)
@@ -955,16 +1125,20 @@ def generic_ap_ft_eap(dev, apdev, vlan=False, cui=False, over_ds=False,
     params["ieee8021x"] = "1"
     if vlan:
         params["dynamic_vlan"] = "1"
+    if wpa_ptk_rekey:
+        params["wpa_ptk_rekey"] = str(wpa_ptk_rekey)
     params = dict(list(radius.items()) + list(params.items()))
     hapd1 = hostapd.add_ap(apdev[1], params)
 
     run_roams(dev[0], apdev, hapd, hapd1, ssid, passphrase, eap=True,
               over_ds=over_ds, roams=roams, eap_identity=identity,
-              conndev=conndev)
+              conndev=conndev, only_one_way=only_one_way)
     if "[WPA2-FT/EAP-CCMP]" not in dev[0].request("SCAN_RESULTS"):
         raise Exception("Scan results missing RSN element info")
-    check_mib(dev[0], [ ("dot11RSNAAuthenticationSuiteRequested", "00-0f-ac-3"),
-                        ("dot11RSNAAuthenticationSuiteSelected", "00-0f-ac-3") ])
+    check_mib(dev[0], [("dot11RSNAAuthenticationSuiteRequested", "00-0f-ac-3"),
+                       ("dot11RSNAAuthenticationSuiteSelected", "00-0f-ac-3")])
+    if only_one_way:
+        return
 
     # Verify EAPOL reauthentication after FT protocol
     if dev[0].get_status_field('bssid') == apdev[0]['bssid']:
@@ -1031,13 +1205,13 @@ def test_ap_ft_eap_vlan_over_ds_multi(dev, apdev):
 def generic_ap_ft_eap_pull(dev, apdev, vlan=False):
     """WPA2-EAP-FT AP (pull PMK)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
     if vlan:
-        identity="gpsk-vlan1"
-        conndev="brvlan1"
+        identity = "gpsk-vlan1"
+        conndev = "brvlan1"
     else:
-        identity="gpsk user"
-        conndev=False
+        identity = "gpsk user"
+        conndev = False
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -1073,7 +1247,7 @@ def test_ap_ft_eap_pull_vlan(dev, apdev):
 def test_ap_ft_eap_pull_wildcard(dev, apdev):
     """WPA2-EAP-FT AP (pull PMK) - wildcard R0KH/R1KH"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase, discovery=True)
@@ -1084,6 +1258,10 @@ def test_ap_ft_eap_pull_wildcard(dev, apdev):
     params["r1kh"] = "00:00:00:00:00:00 00:00:00:00:00:00 00112233445566778899aabbccddeeff00112233445566778899aabbccddeeff"
     params["ft_psk_generate_local"] = "1"
     params["eap_server"] = "0"
+    params["rkh_pos_timeout"] = "100"
+    params["rkh_neg_timeout"] = "50"
+    params["rkh_pull_timeout"] = "1234"
+    params["rkh_pull_retries"] = "10"
     params = dict(list(radius.items()) + list(params.items()))
     hapd = hostapd.add_ap(apdev[0], params)
     params = ft_params2(ssid=ssid, passphrase=passphrase, discovery=True)
@@ -1103,7 +1281,7 @@ def test_ap_ft_eap_pull_wildcard(dev, apdev):
 def test_ap_ft_mismatching_rrb_key_push(dev, apdev):
     """WPA2-PSK-FT AP over DS with mismatching RRB key (push)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -1119,7 +1297,7 @@ def test_ap_ft_mismatching_rrb_key_push(dev, apdev):
 def test_ap_ft_mismatching_rrb_key_pull(dev, apdev):
     """WPA2-PSK-FT AP over DS with mismatching RRB key (pull)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["pmk_r1_push"] = "0"
@@ -1135,7 +1313,7 @@ def test_ap_ft_mismatching_rrb_key_pull(dev, apdev):
 def test_ap_ft_mismatching_r0kh_id_pull(dev, apdev):
     """WPA2-PSK-FT AP over DS with mismatching R0KH-ID (pull)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["pmk_r1_push"] = "0"
@@ -1155,7 +1333,7 @@ def test_ap_ft_mismatching_r0kh_id_pull(dev, apdev):
 def test_ap_ft_mismatching_rrb_r0kh_push(dev, apdev):
     """WPA2-PSK-FT AP over DS with mismatching R0KH key (push)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -1171,7 +1349,7 @@ def test_ap_ft_mismatching_rrb_r0kh_push(dev, apdev):
 def test_ap_ft_mismatching_rrb_r0kh_pull(dev, apdev):
     """WPA2-PSK-FT AP over DS with mismatching R0KH key (pull)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1_r0kh_mismatch(ssid=ssid, passphrase=passphrase)
     params["pmk_r1_push"] = "0"
@@ -1186,7 +1364,7 @@ def test_ap_ft_mismatching_rrb_r0kh_pull(dev, apdev):
 def test_ap_ft_mismatching_rrb_key_push_eap(dev, apdev):
     """WPA2-EAP-FT AP over DS with mismatching RRB key (push)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -1208,7 +1386,7 @@ def test_ap_ft_mismatching_rrb_key_push_eap(dev, apdev):
 def test_ap_ft_mismatching_rrb_key_pull_eap(dev, apdev):
     """WPA2-EAP-FT AP over DS with mismatching RRB key (pull)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -1230,7 +1408,7 @@ def test_ap_ft_mismatching_rrb_key_pull_eap(dev, apdev):
 def test_ap_ft_mismatching_r0kh_id_pull_eap(dev, apdev):
     """WPA2-EAP-FT AP over DS with mismatching R0KH-ID (pull)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -1258,7 +1436,7 @@ def test_ap_ft_mismatching_r0kh_id_pull_eap(dev, apdev):
 def test_ap_ft_mismatching_rrb_r0kh_push_eap(dev, apdev):
     """WPA2-EAP-FT AP over DS with mismatching R0KH key (push)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -1280,7 +1458,7 @@ def test_ap_ft_mismatching_rrb_r0kh_push_eap(dev, apdev):
 def test_ap_ft_mismatching_rrb_r0kh_pull_eap(dev, apdev):
     """WPA2-EAP-FT AP over DS with mismatching R0KH key (pull)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1_r0kh_mismatch(ssid=ssid, passphrase=passphrase)
@@ -1302,7 +1480,7 @@ def test_ap_ft_mismatching_rrb_r0kh_pull_eap(dev, apdev):
 def test_ap_ft_gtk_rekey(dev, apdev):
     """WPA2-PSK-FT AP and GTK rekey"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['wpa_group_rekey'] = '1'
@@ -1334,7 +1512,7 @@ def test_ap_ft_gtk_rekey(dev, apdev):
 def test_ft_psk_key_lifetime_in_memory(dev, apdev, params):
     """WPA2-PSK-FT and key lifetime in memory"""
     ssid = "test-ft"
-    passphrase="04c2726b4b8d5f1b4db9c07aa4d9e9d8f765cb5d25ec817e6cc4fcdd5255db0"
+    passphrase = "04c2726b4b8d5f1b4db9c07aa4d9e9d8f765cb5d25ec817e6cc4fcdd5255db0"
     psk = '93c90846ff67af9037ed83fb72b63dbeddaa81d47f926c20909b5886f1d9358d'
     pmk = binascii.unhexlify(psk)
     p = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -1443,7 +1621,7 @@ def test_ft_psk_key_lifetime_in_memory(dev, apdev, params):
 def test_ap_ft_invalid_resp(dev, apdev):
     """WPA2-PSK-FT AP and invalid response IEs"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1468,7 +1646,7 @@ def test_ap_ft_invalid_resp(dev, apdev):
         # RIC missing from protected IE count.
         "020002000000" + "3603a1b201" + "375200020203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001" + "3900",
         # Protected IE missing.
-        "020002000000" + "3603a1b201" + "375200ff0203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001" + "3900" + "0000" ]
+        "020002000000" + "3603a1b201" + "375200ff0203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001020304050607080900010203040506070809000102030405060708090001" + "3900" + "0000"]
     for t in tests:
         dev[0].scan_for_bss(apdev[1]['bssid'], freq="2412")
         hapd1.set("ext_mgmt_frame_handling", "1")
@@ -1502,7 +1680,7 @@ def test_ap_ft_gcmp_256(dev, apdev):
     if "GCMP-256" not in dev[0].get_capability("pairwise"):
         raise HwsimSkip("Cipher GCMP-256 not supported")
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['rsn_pairwise'] = "GCMP-256"
@@ -1517,7 +1695,7 @@ def test_ap_ft_gcmp_256(dev, apdev):
 def setup_ap_ft_oom(dev, apdev):
     skip_with_fips(dev[0])
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1556,7 +1734,7 @@ def test_ap_ft_oom3(dev, apdev):
 def test_ap_ft_oom4(dev, apdev):
     """WPA2-PSK-FT and OOM (4)"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
     dst = setup_ap_ft_oom(dev, apdev)
     dev[0].request("REMOVE_NETWORK all")
     with alloc_fail(dev[0], 1, "=sme_update_ft_ies"):
@@ -1566,7 +1744,7 @@ def test_ap_ft_oom4(dev, apdev):
 def test_ap_ft_ap_oom(dev, apdev):
     """WPA2-PSK-FT and AP OOM"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1587,7 +1765,7 @@ def test_ap_ft_ap_oom(dev, apdev):
 def test_ap_ft_ap_oom2(dev, apdev):
     """WPA2-PSK-FT and AP OOM 2"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1611,7 +1789,7 @@ def test_ap_ft_ap_oom2(dev, apdev):
 def test_ap_ft_ap_oom3(dev, apdev):
     """WPA2-PSK-FT and AP OOM 3"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1640,7 +1818,7 @@ def test_ap_ft_ap_oom3(dev, apdev):
 def test_ap_ft_ap_oom3b(dev, apdev):
     """WPA2-PSK-FT and AP OOM 3b"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1661,7 +1839,7 @@ def test_ap_ft_ap_oom3b(dev, apdev):
 def test_ap_ft_ap_oom4(dev, apdev):
     """WPA2-PSK-FT and AP OOM 4"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1693,7 +1871,7 @@ def test_ap_ft_ap_oom4(dev, apdev):
 def test_ap_ft_ap_oom5(dev, apdev):
     """WPA2-PSK-FT and AP OOM 5"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1730,7 +1908,7 @@ def test_ap_ft_ap_oom5(dev, apdev):
 def test_ap_ft_ap_oom6(dev, apdev):
     """WPA2-PSK-FT and AP OOM 6"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1754,7 +1932,7 @@ def test_ap_ft_ap_oom6(dev, apdev):
 def test_ap_ft_ap_oom7a(dev, apdev):
     """WPA2-PSK-FT and AP OOM 7a"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -1777,7 +1955,7 @@ def test_ap_ft_ap_oom7a(dev, apdev):
 def test_ap_ft_ap_oom7b(dev, apdev):
     """WPA2-PSK-FT and AP OOM 7b"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -1800,7 +1978,7 @@ def test_ap_ft_ap_oom7b(dev, apdev):
 def test_ap_ft_ap_oom7c(dev, apdev):
     """WPA2-PSK-FT and AP OOM 7c"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -1823,7 +2001,7 @@ def test_ap_ft_ap_oom7c(dev, apdev):
 def test_ap_ft_ap_oom7d(dev, apdev):
     """WPA2-PSK-FT and AP OOM 7d"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "2"
@@ -1846,7 +2024,7 @@ def test_ap_ft_ap_oom7d(dev, apdev):
 def test_ap_ft_ap_oom8(dev, apdev):
     """WPA2-PSK-FT and AP OOM 8"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params['ft_psk_generate_local'] = "1"
@@ -1872,7 +2050,7 @@ def test_ap_ft_ap_oom8(dev, apdev):
 def test_ap_ft_ap_oom9(dev, apdev):
     """WPA2-PSK-FT and AP OOM 9"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1908,7 +2086,7 @@ def test_ap_ft_ap_oom9(dev, apdev):
 def test_ap_ft_ap_oom10(dev, apdev):
     """WPA2-PSK-FT and AP OOM 10"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1950,7 +2128,7 @@ def test_ap_ft_ap_oom10(dev, apdev):
 def test_ap_ft_ap_oom11(dev, apdev):
     """WPA2-PSK-FT and AP OOM 11"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1971,7 +2149,7 @@ def test_ap_ft_ap_oom11(dev, apdev):
 def test_ap_ft_over_ds_proto_ap(dev, apdev):
     """WPA2-PSK-FT AP over DS protocol testing for AP processing"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -1990,26 +2168,26 @@ def test_ap_ft_over_ds_proto_ap(dev, apdev):
     hapd0.set("ext_mgmt_frame_handling", "1")
     hdr = "d0003a01" + _bssid0 + _addr + _bssid0 + "1000"
     valid = "0601" + _addr + _bssid1
-    tests = [ "0601",
-              "0601" + _addr,
-              "0601" + _addr + _bssid0,
-              "0601" + _addr + "ffffffffffff",
-              "0601" + _bssid0 + _bssid0,
-              valid,
-              valid + "01",
-              valid + "3700",
-              valid + "3600",
-              valid + "3603ffffff",
-              valid + "3603a1b2ff",
-              valid + "3603a1b2ff" + "3700",
-              valid + "3603a1b2ff" + "37520000" + 16*"00" + 32*"00" + 32*"00",
-              valid + "3603a1b2ff" + "37520001" + 16*"00" + 32*"00" + 32*"00",
-              valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa",
-              valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "3000",
-              valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "30260100000fac040100000fac040100000facff00000100a225368fe0983b5828a37a0acb37f253",
-              valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "30260100000fac040100000fac030100000fac0400000100a225368fe0983b5828a37a0acb37f253",
-              valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "30260100000fac040100000fac040100000fac0400000100a225368fe0983b5828a37a0acb37f253",
-              valid + "0001" ]
+    tests = ["0601",
+             "0601" + _addr,
+             "0601" + _addr + _bssid0,
+             "0601" + _addr + "ffffffffffff",
+             "0601" + _bssid0 + _bssid0,
+             valid,
+             valid + "01",
+             valid + "3700",
+             valid + "3600",
+             valid + "3603ffffff",
+             valid + "3603a1b2ff",
+             valid + "3603a1b2ff" + "3700",
+             valid + "3603a1b2ff" + "37520000" + 16*"00" + 32*"00" + 32*"00",
+             valid + "3603a1b2ff" + "37520001" + 16*"00" + 32*"00" + 32*"00",
+             valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa",
+             valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "3000",
+             valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "30260100000fac040100000fac040100000facff00000100a225368fe0983b5828a37a0acb37f253",
+             valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "30260100000fac040100000fac030100000fac0400000100a225368fe0983b5828a37a0acb37f253",
+             valid + "3603a1b2ff" + "37550000" + 16*"00" + 32*"00" + 32*"00" + "0301aa" + "30260100000fac040100000fac040100000fac0400000100a225368fe0983b5828a37a0acb37f253",
+             valid + "0001"]
     for t in tests:
         hapd0.dump_monitor()
         if "OK" not in hapd0.request("MGMT_RX_PROCESS freq=2412 datarate=0 ssi_signal=-30 frame=" + hdr + t):
@@ -2020,7 +2198,7 @@ def test_ap_ft_over_ds_proto_ap(dev, apdev):
 def test_ap_ft_over_ds_proto(dev, apdev):
     """WPA2-PSK-FT AP over DS protocol testing"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -2072,7 +2250,7 @@ def test_ap_ft_over_ds_proto(dev, apdev):
 def test_ap_ft_rrb(dev, apdev):
     """WPA2-PSK-FT RRB protocol testing"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -2080,8 +2258,8 @@ def test_ap_ft_rrb(dev, apdev):
     dev[0].connect(ssid, psk=passphrase, key_mgmt="FT-PSK", proto="WPA2",
                    scan_freq="2412")
 
-    _dst_ll = binascii.unhexlify(apdev[0]['bssid'].replace(':',''))
-    _src_ll = binascii.unhexlify(dev[0].own_addr().replace(':',''))
+    _dst_ll = binascii.unhexlify(apdev[0]['bssid'].replace(':', ''))
+    _src_ll = binascii.unhexlify(dev[0].own_addr().replace(':', ''))
     proto = b'\x89\x0d'
     ehdr = _dst_ll + _src_ll + proto
 
@@ -2165,7 +2343,7 @@ def test_rsn_ie_proto_ft_psk_sta(dev, apdev):
     """RSN element protocol testing for FT-PSK + PMF cases on STA side"""
     bssid = apdev[0]['bssid']
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["ieee80211w"] = "1"
@@ -2176,17 +2354,17 @@ def test_rsn_ie_proto_ft_psk_sta(dev, apdev):
                         ieee80211w="1", scan_freq="2412",
                         pairwise="CCMP", group="CCMP")
 
-    tests = [ ('PMKIDCount field included',
-               '30160100000fac040100000fac040100000fac048c000000' + '3603a1b201'),
-              ('Extra IE before RSNE',
-               'dd0400000000' + '30140100000fac040100000fac040100000fac048c00' + '3603a1b201'),
-              ('PMKIDCount and Group Management Cipher suite fields included',
-               '301a0100000fac040100000fac040100000fac048c000000000fac06' + '3603a1b201'),
-              ('Extra octet after defined fields (future extensibility)',
-               '301b0100000fac040100000fac040100000fac048c000000000fac0600' + '3603a1b201'),
-              ('No RSN Capabilities field (PMF disabled in practice)',
-               '30120100000fac040100000fac040100000fac04' + '3603a1b201') ]
-    for txt,ie in tests:
+    tests = [('PMKIDCount field included',
+              '30160100000fac040100000fac040100000fac048c000000' + '3603a1b201'),
+             ('Extra IE before RSNE',
+              'dd0400000000' + '30140100000fac040100000fac040100000fac048c00' + '3603a1b201'),
+             ('PMKIDCount and Group Management Cipher suite fields included',
+              '301a0100000fac040100000fac040100000fac048c000000000fac06' + '3603a1b201'),
+             ('Extra octet after defined fields (future extensibility)',
+              '301b0100000fac040100000fac040100000fac048c000000000fac0600' + '3603a1b201'),
+             ('No RSN Capabilities field (PMF disabled in practice)',
+              '30120100000fac040100000fac040100000fac04' + '3603a1b201')]
+    for txt, ie in tests:
         dev[0].request("DISCONNECT")
         dev[0].wait_disconnected()
         logger.info(txt)
@@ -2229,62 +2407,73 @@ def test_rsn_ie_proto_ft_psk_sta(dev, apdev):
         raise Exception("Unexpected connection")
     dev[0].request("DISCONNECT")
 
-def test_ap_ft_ptk_rekey(dev, apdev):
-    """WPA2-PSK-FT PTK rekeying triggered by station after roam"""
+def start_ft(apdev, wpa_ptk_rekey=None):
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
+    if wpa_ptk_rekey:
+        params['wpa_ptk_rekey'] = str(wpa_ptk_rekey)
     hapd0 = hostapd.add_ap(apdev[0], params)
     params = ft_params2(ssid=ssid, passphrase=passphrase)
+    if wpa_ptk_rekey:
+        params['wpa_ptk_rekey'] = str(wpa_ptk_rekey)
     hapd1 = hostapd.add_ap(apdev[1], params)
 
-    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, ptk_rekey="1")
+    return hapd0, hapd1
 
-    ev = dev[0].wait_event(["CTRL-EVENT-DISCONNECTED",
-                            "WPA: Key negotiation completed"], timeout=5)
+def check_ptk_rekey(dev, hapd0=None, hapd1=None):
+    ev = dev.wait_event(["CTRL-EVENT-DISCONNECTED",
+                         "WPA: Key negotiation completed"], timeout=5)
     if ev is None:
         raise Exception("No event received after roam")
     if "CTRL-EVENT-DISCONNECTED" in ev:
         raise Exception("Unexpected disconnection after roam")
 
-    if dev[0].get_status_field('bssid') == apdev[0]['bssid']:
+    if not hapd0 or not hapd1:
+        return
+    if dev.get_status_field('bssid') == hapd0.own_addr():
         hapd = hapd0
     else:
         hapd = hapd1
-    hwsim_utils.test_connectivity(dev[0], hapd)
-
-def test_ap_ft_ptk_rekey_ap(dev, apdev):
-    """WPA2-PSK-FT PTK rekeying triggered by AP after roam"""
-    ssid = "test-ft"
-    passphrase="12345678"
+    time.sleep(0.1)
+    hwsim_utils.test_connectivity(dev, hapd)
 
-    params = ft_params1(ssid=ssid, passphrase=passphrase)
-    params['wpa_ptk_rekey'] = '2'
-    hapd0 = hostapd.add_ap(apdev[0], params)
-    params = ft_params2(ssid=ssid, passphrase=passphrase)
-    params['wpa_ptk_rekey'] = '2'
-    hapd1 = hostapd.add_ap(apdev[1], params)
+def test_ap_ft_ptk_rekey(dev, apdev):
+    """WPA2-PSK-FT PTK rekeying triggered by station after roam"""
+    hapd0, hapd1 = start_ft(apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", ptk_rekey="1")
+    check_ptk_rekey(dev[0], hapd0, hapd1)
 
-    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase)
+def test_ap_ft_ptk_rekey2(dev, apdev):
+    """WPA2-PSK-FT PTK rekeying triggered by station after one roam"""
+    hapd0, hapd1 = start_ft(apdev)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678", ptk_rekey="1",
+              only_one_way=True)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
 
-    ev = dev[0].wait_event(["CTRL-EVENT-DISCONNECTED",
-                            "WPA: Key negotiation completed"], timeout=5)
-    if ev is None:
-        raise Exception("No event received after roam")
-    if "CTRL-EVENT-DISCONNECTED" in ev:
-        raise Exception("Unexpected disconnection after roam")
-
-    if dev[0].get_status_field('bssid') == apdev[0]['bssid']:
-        hapd = hapd0
-    else:
-        hapd = hapd1
-    hwsim_utils.test_connectivity(dev[0], hapd)
+def test_ap_ft_ptk_rekey_ap(dev, apdev):
+    """WPA2-PSK-FT PTK rekeying triggered by AP after roam"""
+    hapd0, hapd1 = start_ft(apdev, wpa_ptk_rekey=2)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678")
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
+def test_ap_ft_ptk_rekey_ap2(dev, apdev):
+    """WPA2-PSK-FT PTK rekeying triggered by AP after one roam"""
+    hapd0, hapd1 = start_ft(apdev, wpa_ptk_rekey=2)
+    run_roams(dev[0], apdev, hapd0, hapd1, "test-ft", "12345678",
+              only_one_way=True)
+    check_ptk_rekey(dev[0], hapd0, hapd1)
+
+def test_ap_ft_eap_ptk_rekey_ap(dev, apdev):
+    """WPA2-EAP-FT PTK rekeying triggered by AP"""
+    generic_ap_ft_eap(dev, apdev, only_one_way=True, wpa_ptk_rekey=2)
+    check_ptk_rekey(dev[0])
 
 def test_ap_ft_internal_rrb_check(dev, apdev):
     """RRB internal delivery only to WPA enabled BSS"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -2296,7 +2485,7 @@ def test_ap_ft_internal_rrb_check(dev, apdev):
     if key_mgmt.split(' ')[0] != "FT-EAP":
         raise Exception("Unexpected GET_CONFIG(key_mgmt): " + key_mgmt)
 
-    hapd1 = hostapd.add_ap(apdev[1], { "ssid" : ssid })
+    hapd1 = hostapd.add_ap(apdev[1], {"ssid": ssid})
 
     # Connect to WPA enabled AP
     dev[0].connect(ssid, key_mgmt="FT-EAP", proto="WPA2", ieee80211w="1",
@@ -2311,7 +2500,7 @@ def test_ap_ft_internal_rrb_check(dev, apdev):
 def test_ap_ft_extra_ie(dev, apdev):
     """WPA2-PSK-FT AP with WPA2-PSK enabled and unexpected MDE"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["wpa_key_mgmt"] = "WPA-PSK FT-PSK"
@@ -2340,7 +2529,7 @@ def test_ap_ft_extra_ie(dev, apdev):
 def test_ap_ft_ric(dev, apdev):
     """WPA2-PSK-FT AP and RIC"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -2352,14 +2541,14 @@ def test_ap_ft_ric(dev, apdev):
     if "FAIL" not in dev[0].request("SET ric_ies q"):
         raise Exception("Invalid ric_ies value accepted")
 
-    tests = [ "3900",
-              "3900ff04eeeeeeee",
-              "390400000000",
-              "390400000000" + "390400000000",
-              "390400000000" + "dd050050f20202",
-              "390400000000" + "dd3d0050f2020201" + 55*"00",
-              "390400000000" + "dd3d0050f2020201aa300010270000000000000000000000000000000000000000000000000000ffffff7f00000000000000000000000040420f00ffff0000",
-              "390401010000" + "dd3d0050f2020201aa3000dc050000000000000000000000000000000000000000000000000000dc050000000000000000000000000000808d5b0028230000" ]
+    tests = ["3900",
+             "3900ff04eeeeeeee",
+             "390400000000",
+             "390400000000" + "390400000000",
+             "390400000000" + "dd050050f20202",
+             "390400000000" + "dd3d0050f2020201" + 55*"00",
+             "390400000000" + "dd3d0050f2020201aa300010270000000000000000000000000000000000000000000000000000ffffff7f00000000000000000000000040420f00ffff0000",
+             "390401010000" + "dd3d0050f2020201aa3000dc050000000000000000000000000000000000000000000000000000dc050000000000000000000000000000808d5b0028230000"]
     for t in tests:
         dev[0].set("ric_ies", t)
         run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase,
@@ -2374,7 +2563,7 @@ def ie_hex(ies, id):
 def test_ap_ft_reassoc_proto(dev, apdev):
     """WPA2-PSK-FT AP Reassociation Request frame parsing"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -2415,43 +2604,43 @@ def test_ap_ft_reassoc_proto(dev, apdev):
     rsne = ie_hex(ies, 48)
     mde = ie_hex(ies, 54)
     fte = ie_hex(ies, 55)
-    tests = [ ]
+    tests = []
     # RSN: Trying to use FT, but MDIE not included
-    tests += [ rsne ]
+    tests += [rsne]
     # RSN: Attempted to use unknown MDIE
-    tests += [ rsne + "3603000000" ]
+    tests += [rsne + "3603000000"]
     # Invalid RSN pairwise cipher
-    tests += [ "30260100000fac040100000fac030100000fac040000010029208a42cd25c85aa571567dce10dae3" ]
+    tests += ["30260100000fac040100000fac030100000fac040000010029208a42cd25c85aa571567dce10dae3"]
     # FT: No PMKID in RSNIE
-    tests += [ "30160100000fac040100000fac040100000fac0400000000" + ie_hex(ies, 54) ]
+    tests += ["30160100000fac040100000fac040100000fac0400000000" + ie_hex(ies, 54)]
     # FT: Invalid FTIE
-    tests += [ rsne + mde ]
+    tests += [rsne + mde]
     # FT: RIC IE(s) in the frame, but not included in protected IE count
     # FT: Failed to parse FT IEs
-    tests += [ rsne + mde + fte + "3900" ]
+    tests += [rsne + mde + fte + "3900"]
     # FT: SNonce mismatch in FTIE
-    tests += [ rsne + mde + "37520000" + 16*"00" + 32*"00" + 32*"00" ]
+    tests += [rsne + mde + "37520000" + 16*"00" + 32*"00" + 32*"00"]
     # FT: ANonce mismatch in FTIE
-    tests += [ rsne + mde + fte[0:40] + 32*"00" + fte[104:] ]
+    tests += [rsne + mde + fte[0:40] + 32*"00" + fte[104:]]
     # FT: No R0KH-ID subelem in FTIE
-    tests += [ rsne + mde + "3752" + fte[4:168] ]
+    tests += [rsne + mde + "3752" + fte[4:168]]
     # FT: R0KH-ID in FTIE did not match with the current R0KH-ID
-    tests += [ rsne + mde + "3755" + fte[4:168] + "0301ff" ]
+    tests += [rsne + mde + "3755" + fte[4:168] + "0301ff"]
     # FT: No R1KH-ID subelem in FTIE
-    tests += [ rsne + mde + "375e" + fte[4:168] + "030a" + binascii.hexlify(b"nas1.w1.fi").decode() ]
+    tests += [rsne + mde + "375e" + fte[4:168] + "030a" + binascii.hexlify(b"nas1.w1.fi").decode()]
     # FT: Unknown R1KH-ID used in ReassocReq
-    tests += [ rsne + mde + "3766" + fte[4:168] + "030a" + binascii.hexlify(b"nas1.w1.fi").decode() + "0106000000000000" ]
+    tests += [rsne + mde + "3766" + fte[4:168] + "030a" + binascii.hexlify(b"nas1.w1.fi").decode() + "0106000000000000"]
     # FT: PMKID in Reassoc Req did not match with the PMKR1Name derived from auth request
-    tests += [ rsne[:-32] + 16*"00" + mde + fte ]
+    tests += [rsne[:-32] + 16*"00" + mde + fte]
     # Invalid MIC in FTIE
-    tests += [ rsne + mde + fte[0:8] + 16*"00" + fte[40:] ]
+    tests += [rsne + mde + fte[0:8] + 16*"00" + fte[40:]]
     for t in tests:
         hapd2ap.request("MGMT_RX_PROCESS freq=2412 datarate=0 ssi_signal=-30 frame=" + hdr + ies1 + t)
 
 def test_ap_ft_reassoc_local_fail(dev, apdev):
     """WPA2-PSK-FT AP Reassociation Request frame and local failure"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -2480,7 +2669,7 @@ def test_ap_ft_reassoc_replay(dev, apdev, params):
     """WPA2-PSK-FT AP and replayed Reassociation Request frame"""
     capfile = os.path.join(params['logdir'], "hwsim0.pcapng")
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     hapd0 = hostapd.add_ap(apdev[0], params)
@@ -2549,8 +2738,9 @@ def test_ap_ft_reassoc_replay(dev, apdev, params):
     sta = dev[0].own_addr()
     filt = "wlan.fc.type == 2 && " + \
            "wlan.da == " + sta + " && " + \
-           "wlan.sa == " + ap
-    fields = [ "wlan.ccmp.extiv" ]
+           "wlan.sa == " + ap + " && " + \
+           "wlan.fc.protected == 1"
+    fields = ["wlan.ccmp.extiv"]
     res = run_tshark(capfile, filt, fields)
     vals = res.splitlines()
     logger.info("CCMP PN: " + str(vals))
@@ -2565,7 +2755,7 @@ def test_ap_ft_reassoc_replay(dev, apdev, params):
 def test_ap_ft_psk_file(dev, apdev):
     """WPA2-PSK-FT AP with PSK from a file"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1a(ssid=ssid, passphrase=passphrase)
     params['wpa_psk_file'] = 'hostapd.wpa_psk'
@@ -2596,7 +2786,7 @@ def test_ap_ft_psk_file(dev, apdev):
 def test_ap_ft_eap_ap_config_change(dev, apdev):
     """WPA2-EAP-FT AP changing from 802.1X-only to FT-only"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
     bssid = apdev[0]['bssid']
 
     radius = hostapd.radius_params()
@@ -2631,7 +2821,7 @@ def test_ap_ft_eap_ap_config_change(dev, apdev):
 def test_ap_ft_eap_sha384(dev, apdev):
     """WPA2-EAP-FT with SHA384"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -2650,10 +2840,33 @@ def test_ap_ft_eap_sha384(dev, apdev):
     run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, eap=True,
               sha384=True)
 
+def test_ap_ft_eap_sha384_reassoc(dev, apdev):
+    """WPA2-EAP-FT with SHA384 using REASSOCIATE"""
+    check_suite_b_192_capa(dev)
+    ssid = "test-ft"
+    passphrase = "12345678"
+
+    radius = hostapd.radius_params()
+    params = ft_params1(ssid=ssid, passphrase=passphrase)
+    params["ieee80211w"] = "2"
+    params['wpa_key_mgmt'] = "WPA-EAP-SUITE-B-192 FT-EAP-SHA384"
+    params["ieee8021x"] = "1"
+    params = dict(list(radius.items()) + list(params.items()))
+    hapd0 = hostapd.add_ap(apdev[0], params)
+    params = ft_params2(ssid=ssid, passphrase=passphrase)
+    params["ieee80211w"] = "2"
+    params['wpa_key_mgmt'] = "WPA-EAP-SUITE-B-192 FT-EAP-SHA384"
+    params["ieee8021x"] = "1"
+    params = dict(list(radius.items()) + list(params.items()))
+    hapd1 = hostapd.add_ap(apdev[1], params)
+
+    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, eap=True,
+              sha384=True, also_non_ft=True, roam_with_reassoc=True)
+
 def test_ap_ft_eap_sha384_over_ds(dev, apdev):
     """WPA2-EAP-FT with SHA384 over DS"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     radius = hostapd.radius_params()
     params = ft_params1(ssid=ssid, passphrase=passphrase)
@@ -2675,7 +2888,7 @@ def test_ap_ft_eap_sha384_over_ds(dev, apdev):
 def test_ap_ft_roam_rrm(dev, apdev):
     """WPA2-PSK-FT AP and radio measurement request"""
     ssid = "test-ft"
-    passphrase="12345678"
+    passphrase = "12345678"
 
     params = ft_params1(ssid=ssid, passphrase=passphrase)
     params["rrm_beacon_report"] = "1"
@@ -2699,3 +2912,97 @@ def test_ap_ft_roam_rrm(dev, apdev):
     dev[0].scan_for_bss(bssid0, freq=2412)
     dev[0].roam(bssid0)
     check_beacon_req(hapd0, addr, 3)
+
+def test_ap_ft_pmksa_caching(dev, apdev):
+    """FT-EAP and PMKSA caching for initial mobility domain association"""
+    ssid = "test-ft"
+    identity = "gpsk user"
+
+    radius = hostapd.radius_params()
+    params = ft_params1(ssid=ssid)
+    params['wpa_key_mgmt'] = "FT-EAP"
+    params["ieee8021x"] = "1"
+    params["mobility_domain"] = "c3d4"
+    params = dict(list(radius.items()) + list(params.items()))
+    hapd = hostapd.add_ap(apdev[0], params)
+
+    params = ft_params2(ssid=ssid)
+    params['wpa_key_mgmt'] = "FT-EAP"
+    params["ieee8021x"] = "1"
+    params["mobility_domain"] = "c3d4"
+    params = dict(list(radius.items()) + list(params.items()))
+    hapd1 = hostapd.add_ap(apdev[1], params)
+
+    run_roams(dev[0], apdev, hapd, hapd1, ssid, None, eap=True,
+              eap_identity=identity, pmksa_caching=True)
+
+def test_ap_ft_pmksa_caching_sha384(dev, apdev):
+    """FT-EAP-SHA384 and PMKSA caching for initial mobility domain association"""
+    ssid = "test-ft"
+    identity = "gpsk user"
+
+    radius = hostapd.radius_params()
+    params = ft_params1(ssid=ssid)
+    params['wpa_key_mgmt'] = "FT-EAP-SHA384"
+    params["ieee8021x"] = "1"
+    params["mobility_domain"] = "c3d4"
+    params = dict(list(radius.items()) + list(params.items()))
+    hapd = hostapd.add_ap(apdev[0], params)
+
+    params = ft_params2(ssid=ssid)
+    params['wpa_key_mgmt'] = "FT-EAP-SHA384"
+    params["ieee8021x"] = "1"
+    params["mobility_domain"] = "c3d4"
+    params = dict(list(radius.items()) + list(params.items()))
+    hapd1 = hostapd.add_ap(apdev[1], params)
+
+    run_roams(dev[0], apdev, hapd, hapd1, ssid, None, eap=True,
+              eap_identity=identity, pmksa_caching=True, sha384=True)
+
+def test_ap_ft_r1_key_expiration(dev, apdev):
+    """WPA2-PSK-FT and PMK-R1 expiration"""
+    ssid = "test-ft"
+    passphrase = "12345678"
+
+    params = ft_params1(ssid=ssid, passphrase=passphrase)
+    params['r1_max_key_lifetime'] = "2"
+    hapd0 = hostapd.add_ap(apdev[0], params)
+    params = ft_params2(ssid=ssid, passphrase=passphrase)
+    params['r1_max_key_lifetime'] = "2"
+    hapd1 = hostapd.add_ap(apdev[1], params)
+
+    # This succeeds, but results in having to run another PMK-R1 pull before the
+    # second AP can complete FT protocol.
+    run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase, wait_before_roam=4)
+
+def test_ap_ft_r0_key_expiration(dev, apdev):
+    """WPA2-PSK-FT and PMK-R0 expiration"""
+    ssid = "test-ft"
+    passphrase = "12345678"
+
+    params = ft_params1(ssid=ssid, passphrase=passphrase)
+    params['ft_r0_key_lifetime'] = "2"
+    hapd0 = hostapd.add_ap(apdev[0], params)
+    params = ft_params2(ssid=ssid, passphrase=passphrase)
+    params['ft_r0_key_lifetime'] = "2"
+    hapd1 = hostapd.add_ap(apdev[1], params)
+
+    bssid2 = run_roams(dev[0], apdev, hapd0, hapd1, ssid, passphrase,
+                       return_after_initial=True)
+    time.sleep(4)
+    dev[0].scan_for_bss(bssid2, freq="2412")
+    if "OK" not in dev[0].request("ROAM " + bssid2):
+        raise Exception("ROAM failed")
+    ev = dev[0].wait_event(["CTRL-EVENT-CONNECTED",
+                            "CTRL-EVENT-AUTH-REJECT",
+                            "CTRL-EVENT-ASSOC-REJECT"], timeout=5)
+    dev[0].request("DISCONNECT")
+    if ev is None or "CTRL-EVENT-AUTH-REJECT" not in ev:
+        raise Exception("FT protocol failure not reported")
+    if "status_code=53" not in ev:
+        raise Exception("Unexpected status in FT protocol failure: " + ev)
+
+    # Generate a new PMK-R0
+    dev[0].dump_monitor()
+    dev[0].request("RECONNECT")
+    dev[0].wait_connected()