]> git.ipfire.org Git - thirdparty/hostap.git/commit
D-Bus: Fix P2P GroupStarted signal not to use uninitialized IP buffer
authorJouni Malinen <jouni@codeaurora.org>
Mon, 15 Apr 2019 17:27:52 +0000 (20:27 +0300)
committerJouni Malinen <j@w1.fi>
Mon, 15 Apr 2019 17:27:52 +0000 (20:27 +0300)
commit2e70e807c8b89ce7b28c3d91843f89ef56e7fa7a
treee5118c7ccb6d4f4fd182a91a89fdce8e6a3e74dc
parent6541b9dbe759a23d5a80061bd294b205d36025a8
D-Bus: Fix P2P GroupStarted signal not to use uninitialized IP buffer

wpas_p2p_completed() used wpa_sm_get_p2p_ip_addr() return value properly
for filling in the ip_addr[] string only if the IP addresses got
assigned, but the raw ip[] array was passed to
wpas_dbus_signal_p2p_group_started() regardless of whether the IP
addresses were assigned. This could result in using uninitialized stack
memory for constructing the GroupStarted signal values. Fix this by
filling those in only if the IP addressed are actually available.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
wpa_supplicant/p2p_supplicant.c