]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
FT RRB: Remove confusing debug print about extra data
authorJouni Malinen <j@w1.fi>
Sat, 4 Apr 2020 20:42:05 +0000 (23:42 +0300)
committerJouni Malinen <j@w1.fi>
Sat, 4 Apr 2020 20:42:05 +0000 (23:42 +0300)
The "FT: Ignore extra data in end" hexdump is quite confusing since it
shows all the IEs that were actually either processed or forwarded.
There is no code path that could reach this debug print with actual real
extra data. Remove it and the dead increment of pos to avoid warnings
from static analyzers.

Signed-off-by: Jouni Malinen <j@w1.fi>
src/ap/wpa_auth_ft.c

index 6f6c18eecbc831003e7d122f7c8e80ed24ab3188..4ca18ab6bcf91c62895fd033bc66334d63dc7f27 100644 (file)
@@ -4572,7 +4572,6 @@ int wpa_ft_rrb_rx(struct wpa_authenticator *wpa_auth, const u8 *src_addr,
                        return -1;
                }
                status_code = WPA_GET_LE16(pos);
-               pos += 2;
 
                wpa_printf(MSG_DEBUG, "FT: FT Packet Type - Response "
                           "(status_code=%d)", status_code);
@@ -4585,11 +4584,6 @@ int wpa_ft_rrb_rx(struct wpa_authenticator *wpa_auth, const u8 *src_addr,
                return -1;
        }
 
-       if (end > pos) {
-               wpa_hexdump(MSG_DEBUG, "FT: Ignore extra data in end",
-                           pos, end - pos);
-       }
-
        return 0;
 }