tests: WPA2-PSK-FT AP over DS disabled

Signed-off-by: Jouni Malinen <j@w1.fi>

FT: Drop FT Action frames if ft_over_ds=0

Previously, the hostapd ft_over_ds parameter was used to only advertise
whether FT-over-DS is enabled in MDE and leave it to the stations to
follow that advertisement. This commit extends this to explicitly reject
(silently drop) FT Action frames if a station does not follow the
advertised capabilities.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: RADIUS Dynamic Authorization Extensions - Disconnect - time window

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Additional radius_auth/acct_req_attr coverage

The third attribute is needed in the list to cover full parsing code
coverage.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: IEEE 802.1X and EAPOL-Key index workaround

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: WPA2-Enterprise using EAP-SIM with zero database timeout

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: EAP-FAST and provisioning options

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd eapol_version configuration

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd configuration SET OOM and error cases

Signed-off-by: Jouni Malinen <j@w1.fi>

Remove deprecated tx_queue_* params from hostapd.conf notes

The after_beacon and beacon TX queue parameters has not been
configurable through this mechanism for years, so do not list them in
hostapd.conf notes.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd eap_user_file parsing

Signed-off-by: Jouni Malinen <j@w1.fi>

Fix memory leak on hostapd eap_user_file parsing error paths

Need to free all the pending completed EAP users if a parsing error
prevents the file from being used.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd vlan_file/mac_file parsing

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Remove unnecessary NULL check from parser functions

The fname argument cannot be NULL in these location.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd global ctrl_iface DETACH failure

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and TEST_ALLOC_FAIL/TEST_FAIL

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and SET accept_mac_file ctrl_iface command (VLAN ID)

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd global control interface with unknown IFNAME= prefix

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd DUP_NETWORK error cases

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd global ctrl_iface INTERFACES

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and UPDATE_BEACON

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and POLL_STA errors

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Invalid hostapd STA ctrl_iface command subparameter

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: sae_group in hostapd STA ctrl_iface command

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and RELOG

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More SET_NEIGHBOR and REMOVE_NEIGHBOR error cases

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More hostapd REQ_RANGE error case coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and EAPOL_REAUTH errors

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and VENDOR errors

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and external I/O errors

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd and RADAR ctrl_iface command

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: WPS PIN provisioning with configured AP using dummy cred

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More hostapd SET command coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More hostapd GET_CONFIG key_mgmt coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More BSS_TM_REQ coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

Fix memory leak in hostapd BSS_TM_REQ error path handling

The optional url=<URL> parameter was stored in allocated memory and that
memory was leaked if some following parameter parsing attempts failed.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More hostapd ctrl_iface QoS Map error coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: HS20_DEAUTH_REQ OOM

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Additional HS20_WNM_NOTIF coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

Remove trailing whitespace

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Remove trailing whitespace

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Additional hostapd WPS control interface coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Additional SA_QUERY coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Additional hostapd NEW_STA coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd BSS config file

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Add TERMINATE as per-interface command

This was already avaialble through the global control interface, but not
the per-interface one.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd -i command line argument

This adds some more code coverage reachability testing.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd SIGUSR1

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Ignoring invalid hostapd configuration parameter updates

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Do not update dtim_period with invalid value

Previously, the update command was rejected, but the actual value was
updated.

Signed-off-by: Jouni Malinen <j@w1.fi>

RADIUS server: Increase maximum number of sessions

It was possible to hit the previously used maximum of 100 active session
in some hwsim test case sequences like this one: eap_proto_pwd_errors
eap_proto_ikev2_errors eap_proto_sim_errors. This happened due to the
large number of RADIUS authentication iterations in short period of
time, i.e., within the 10 second timeout for expiring completed
sessions.

Increase RADIUS_MAX_SESSION from 100 to 1000 and also reduce the timeout
on expiring completed sessions from 10 to 5 seconds.

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Do not update invalid wep_key_len_unicast

Previously, the update command was rejected, but the configuration
parameter value was updated anyway.

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Do not update rejected wep_key_len_broadcast

Previously, update command with invalid value got rejected, but the
actual configuration data was updated anyway.

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Do not update eapol_version with rejected value

Previously, an invalid eapol_version update command was rejected, but
the actual configuration value was updated.

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Reject invalid macaddr_acl value

Previously, this was noted in error log, but the invalid value was
stored in the configuration without rejecting it.

Signed-off-by: Jouni Malinen <j@w1.fi>

hostapd: Check driver parameter before replacing previous value

This leaves the previously configured value in place if "SET driver ..."
command fails.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: hostapd configuration reload

Signed-off-by: Jouni Malinen <j@w1.fi>

Fix hostapd SIGHUP processing before interface is enabled

It was possible to try to do driver operations before the driver
interface had been initialized when processing a SIGHUP signal. This
would result in NULL pointer dereference. Fix this by skipping the steps
when SIGHUP is issued before the interface is enabled.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: IEEE 802.1X connection using static WEP104

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Invalid TX queue params set (cwmin/cwmax)

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: MBO and WPA2 without PMF

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: WPS getting disabled due to conflicting parameters

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: VHT and TKIP

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Duplicate BSSID

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: WPA2-PSK AP and no PSK configured

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Invalid VLAN ID from RADIUS server for ACL

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Cover both binary search branches in hostapd_maclist_found()

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Make hostapd_oom_wpa2_psk catch cases more robustly

For some reason, a potential OOM in hostapd_config_read_wpa_psk() and
hostapd_derive_psk() were missed in --codecov runs during the main
iteration loop. Cover these specific cases with separate instances to
avoid missing coverage.

Signed-off-by: Jouni Malinen <j@w1.fi>

Remove unnecessary NULL check from hostapd_config_read_wpa_psk() call

This function is already checking the fname argument against NULL, so
use that check on its own instead of duplicating the check in the only
caller.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: FILS SK authentication with SHA384

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More ieee802_11_vendor_ie_concat() coverage

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: VHT with 160 MHz channel width and HT40 disabled

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: VHT 160 MHz tests with all different HT primary channels

This extends previous ap_vht160_no_dfs test case coverage by running the
same test case with each of the possible HT primary channel
alternatives.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: SAE protocol testing with hostapd

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Remove src/common/cli.c from code coverage report

This file is used only by hostapd_cli and wpa_cli and neither of those
are currently included in code coverage reporting. Avoid dropping the
coverage numbers by code that cannot be reached due to not being
included in the programs that are covered.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: More ieee802_11_parse_elems() coverage for new elements

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Operating classes with HT20 and HT40 channels

Signed-off-by: Jouni Malinen <j@w1.fi>

mka: Make MKA actor priority configurable

This adds a new wpa_supplicant network profile parameter
mka_priority=0..255 to set the priority of the MKA Actor.

Signed-off-by: Badrish Adiga H R <badrish.adigahr@gmail.com>

tests: Fix p2p_autogo_pref_chan_not_in_regulatory with new regdb

5745 MHz was added as an allowed short range device range in
wireless-regdb for DE which made this test case fail. Fix it for now by
using SE instead of DE for the second part of the test case.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Fix mesh_open_vht_160 skipping

It is possible for wireless-regdb to include a 160 MHz channel, but with
DFS required. This test case need the regulatory information to allow
160 MHz channel without DFS. Fix false failures by skipping the test if
this exact combination is not found.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Fix peerkey_sniffer_check with newer Wireshark version

Wireshark renamed eapol.keydes.key_info to
wlan_rsna_eapol.keydes.key_info and that broke this test case when
upgrading Wireshark. Fix this by trying to use both the new and the old
name.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Fix eap_fast_tlv_nak_oom and eap_fast_proto_phase2

Something broke eap_fast_tlv_nak_oom when moving from Ubuntu 14.04 to
16.04. OpenSSL.SSL.Connection() state_string() returns None in these
cases and the debug log prints for that were causing the case to fail.
For now, work around this by checking whether the state string is None
before trying to print it.

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Clear monitor socket within p2p_msg_unexpected_go_neg_resp

This makes the debug log easier to understand and avoids leaving large
number of pending messages into the wpa_supplicant control interface
sockets.

Signed-off-by: Jouni Malinen <j@w1.fi>

Document new D-Bus WPS properties

Signed-off-by: Jouni Malinen <j@w1.fi>

tests: Additional D-Bus WPS Get/Set properties

Signed-off-by: Jouni Malinen <j@w1.fi>

D-Bus: Use a helper function to get possibly NULL strings

This type of check is used in quite a few getter functions, so add a
helper function to take care of it.

Signed-off-by: Jouni Malinen <j@w1.fi>

D-Bus: Add DeviceType in WPS property

Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>

D-Bus: Add device serial number in WPS property

Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>

D-Bus: Add model number in WPS property

Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>

D-Bus: Add WPS model name as property

Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
Signed-off-by: Kyeong-Chae Lim <kcya.lim@samsung.com>

D-Bus: Add WPS manufacturer as property

Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
Signed-off-by: Kyeong-Chae Lim <kcya.lim@samsung.com>
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>

D-Bus: Add WPS device name as property

Signed-off-by: Avichal Agarwal <avichal.a@samsung.com>
Signed-off-by: Kyeong-Chae Lim <kcya.lim@samsung.com>
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>

tests: Check MESH flag in BSS output in wpas_mesh_mode_scan

In addition, use a single channel scan to make the test case run faster.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

mesh: Show [MESH] flag in print_bss_info()

This was previously done for SCAN_RESULTS, but the BSS control interface
command did not show a similar flag. In addition, change "WPA2" to "RSN"
for mesh BSS to be consistent with the SCAN_RESULTS output.

Commit 638d945679649da579c4ed734d4ebae87e2307de ('mesh: Show [MESH] flag
in scan results') did similar changes for SCAN_RESULTS.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

hostapd_cli: Add completion for get command

Add command completion support for get command.

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@sonymobile.com>

hostapd_cli: Add completion for set command

Add command completion support for set command.

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@sonymobile.com>

hostapd_cli: Completion for further commands with STA parameter

Yet some more commands take STA address as the only parameter. Add
command completion support for the following commands:

signature, sa_query, send_qos_map_conf and req_lci

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@sonymobile.com>

hostapd_cli: Use common completion for commands that use stations

More than one command takes STA address as the only parameter. Make use
of a common completion routine.

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@sonymobile.com>

hostapd_cli: Add missing command help descriptions

Some commands are missing help description making them not show up in
the list of supported commands. Add command help description for all
missing commands.

Signed-off-by: Mikael Kanstrup <mikael.kanstrup@sonymobile.com>

Fix wpa_cipher_to_alg() return type

wpa_cipher_to_alg() returns enumerated values from enum wpa_alg and all
uses of the return value treat it as enum wpa_alg (by either assigning
it to a variable of type enum wpa_alg or passing to a function that
expects enum wpa_alg).

This commit updates the return value to match the expected usage
(enum  wpa_alg) rather than int. This ensures the return value is
of the proper type and eliminates the following compiler warnings:

ARM RVCT (2.2):
  'Warning: #188-D: enumerated type mixed with another type'

Signed-off-by: Joel Cunningham <joel.cunningham@me.com>