From 153333ef6b67a30fb1581df26815713acdd0e698 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sat, 4 Apr 2020 23:42:05 +0300 Subject: [PATCH] FT RRB: Remove confusing debug print about extra data The "FT: Ignore extra data in end" hexdump is quite confusing since it shows all the IEs that were actually either processed or forwarded. There is no code path that could reach this debug print with actual real extra data. Remove it and the dead increment of pos to avoid warnings from static analyzers. Signed-off-by: Jouni Malinen --- src/ap/wpa_auth_ft.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/ap/wpa_auth_ft.c b/src/ap/wpa_auth_ft.c index 6f6c18eec..4ca18ab6b 100644 --- a/src/ap/wpa_auth_ft.c +++ b/src/ap/wpa_auth_ft.c @@ -4572,7 +4572,6 @@ int wpa_ft_rrb_rx(struct wpa_authenticator *wpa_auth, const u8 *src_addr, return -1; } status_code = WPA_GET_LE16(pos); - pos += 2; wpa_printf(MSG_DEBUG, "FT: FT Packet Type - Response " "(status_code=%d)", status_code); @@ -4585,11 +4584,6 @@ int wpa_ft_rrb_rx(struct wpa_authenticator *wpa_auth, const u8 *src_addr, return -1; } - if (end > pos) { - wpa_hexdump(MSG_DEBUG, "FT: Ignore extra data in end", - pos, end - pos); - } - return 0; } -- 2.39.2