]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: target: core: add missing file_{start,end}_write()
authorAmir Goldstein <amir73il@gmail.com>
Thu, 23 Nov 2023 09:20:00 +0000 (11:20 +0200)
committerChristian Brauner <brauner@kernel.org>
Fri, 24 Nov 2023 08:22:27 +0000 (09:22 +0100)
commit0db1d53937fafa8bb96e077375691e16902f4899
treebdf1d07be0bc9fe58d57e6964ea93d999ad73409
parentb85ea95d086471afb4ad062012a4d73cd328fa86
scsi: target: core: add missing file_{start,end}_write()

The callers of vfs_iter_write() are required to hold file_start_write().
file_start_write() is a no-op for the S_ISBLK() case, but it is really
needed when the backing file is a regular file.

We are going to move file_{start,end}_write() into vfs_iter_write(), but
we need to fix this first, so that the fix could be backported to stable
kernels.

Suggested-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/ZV8ETIpM+wZa33B5@infradead.org/
Cc: <stable@vger.kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20231123092000.2665902-1-amir73il@gmail.com
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
drivers/target/target_core_file.c