]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init
authorHui Wang <hui.wang@canonical.com>
Wed, 30 Nov 2022 09:08:00 +0000 (17:08 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 18 Jan 2023 12:14:29 +0000 (17:44 +0530)
commit1417f59ac0b02130ee56c0c50794b9b257be3d17
tree3c6bf7751d3970818c9fef4768e9a48cab31f46d
parentf3dc1b3b4750851a94212dba249703dd0e50bb20
dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init

If the function sdma_load_context() fails, the sdma_desc will be
freed, but the allocated desc->bd is forgot to be freed.

We already met the sdma_load_context() failure case and the log as
below:
[ 450.699064] imx-sdma 30bd0000.dma-controller: Timeout waiting for CH0 ready
...

In this case, the desc->bd will not be freed without this change.

Signed-off-by: Hui Wang <hui.wang@canonical.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://lore.kernel.org/r/20221130090800.102035-1-hui.wang@canonical.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/imx-sdma.c