]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ovl: fix bogus -Wmaybe-unitialized warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 17 Jun 2019 12:39:29 +0000 (14:39 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Tue, 18 Jun 2019 13:06:16 +0000 (15:06 +0200)
commit1dac6f5b0ed2601be21bb4e27a44b0c3e667b7f4
tree01be29628073cabaf679bdfb672c9903833c677d
parent9179c21dc6ed1c993caa5fe4da876a6765c26af7
ovl: fix bogus -Wmaybe-unitialized warning

gcc gets a bit confused by the logic in ovl_setup_trap() and
can't figure out whether the local 'trap' variable in the caller
was initialized or not:

fs/overlayfs/super.c: In function 'ovl_fill_super':
fs/overlayfs/super.c:1333:4: error: 'trap' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    iput(trap);
    ^~~~~~~~~~
fs/overlayfs/super.c:1312:17: note: 'trap' was declared here

Reword slightly to make it easier for the compiler to understand.

Fixes: 146d62e5a586 ("ovl: detect overlapping layers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/super.c