]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "crypto: pkcs7 - remove sha1 support"
authorEric Biggers <ebiggers@google.com>
Wed, 13 Mar 2024 23:32:27 +0000 (16:32 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 22 Mar 2024 11:42:20 +0000 (19:42 +0800)
commit203a6763ab699da0568fd2b76303d03bb121abd4
treeb2aca92e324484780576cbe147b97042efc00f5e
parent6a8dbd71a70620c42d4fa82509204ba18231f28d
Revert "crypto: pkcs7 - remove sha1 support"

This reverts commit 16ab7cb5825fc3425c16ad2c6e53d827f382d7c6 because it
broke iwd.  iwd uses the KEYCTL_PKEY_* UAPIs via its dependency libell,
and apparently it is relying on SHA-1 signature support.  These UAPIs
are fairly obscure, and their documentation does not mention which
algorithms they support.  iwd really should be using a properly
supported userspace crypto library instead.  Regardless, since something
broke we have to revert the change.

It may be possible that some parts of this commit can be reinstated
without breaking iwd (e.g. probably the removal of MODULE_SIG_SHA1), but
for now this just does a full revert to get things working again.

Reported-by: Karel Balej <balejk@matfyz.cz>
Closes: https://lore.kernel.org/r/CZSHRUIJ4RKL.34T4EASV5DNJM@matfyz.cz
Cc: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Tested-by: Karel Balej <balejk@matfyz.cz>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/asymmetric_keys/mscode_parser.c
crypto/asymmetric_keys/pkcs7_parser.c
crypto/asymmetric_keys/public_key.c
crypto/asymmetric_keys/signature.c
crypto/asymmetric_keys/x509_cert_parser.c
crypto/testmgr.h
include/linux/oid_registry.h
kernel/module/Kconfig