]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ARM: integrator: impd1: use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Sat, 5 Jan 2019 05:55:27 +0000 (23:55 -0600)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 11 Jan 2019 12:33:00 +0000 (13:33 +0100)
commit21face6f0d4d033d949d5517f307a15f76a9d9f2
tree8a6410cd65f28fa27cd94e7662602376c1b7d603
parentdf209c43a0e8258e096fb722dfbdae4f0dd13fde
ARM: integrator: impd1: use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
arch/arm/mach-integrator/impd1.c