]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf annotate: Make sure to call symbol__annotate2() in TUI
authorNamhyung Kim <namhyung@kernel.org>
Fri, 5 Apr 2024 21:17:57 +0000 (14:17 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 11 Apr 2024 17:14:58 +0000 (10:14 -0700)
commit2b8dbf69ec60faf6c7db49e57d7f316409ccec92
tree9097841df1a9231412a9eb7c0f8887bf703b0c85
parentfec50db7033ea478773b159e0e2efb135270e3b7
perf annotate: Make sure to call symbol__annotate2() in TUI

The symbol__annotate2() initializes some data structures needed by TUI.
It has a logic to prevent calling it multiple times by checking if it
has the annotated source.  But data type profiling uses a different
code (symbol__annotate) to allocate the annotated lines in advance.
So TUI missed to call symbol__annotate2() when it shows the annotation
browser.

Make symbol__annotate() reentrant and handle that situation properly.
This fixes a crash in the annotation browser started by perf report in
TUI like below.

  $ perf report -s type,sym --tui
  # and press 'a' key and then move down

Fixes: 81e57deec325 ("perf report: Support data type profiling")
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240405211800.1412920-2-namhyung@kernel.org
tools/perf/ui/browsers/annotate.c
tools/perf/util/annotate.c