]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
crypto: rockchip - remove unnecessary alignmask for ahashes
authorEric Biggers <ebiggers@google.com>
Sun, 22 Oct 2023 08:10:41 +0000 (01:10 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 27 Oct 2023 10:04:29 +0000 (18:04 +0800)
commit2d91a839f5da3836e3b3f27452fe38a84fc403c6
tree42d780ad89fd0ea21702db5100e2fd12231aafe8
parentf35a4e237f4ecfac0cbf51fc840fe70955431fa9
crypto: rockchip - remove unnecessary alignmask for ahashes

The crypto API's support for alignmasks for ahash algorithms is nearly
useless, as its only effect is to cause the API to align the key and
result buffers.  The drivers that happen to be specifying an alignmask
for ahash rarely actually need it.  When they do, it's easily fixable,
especially considering that these buffers cannot be used for DMA.

In preparation for removing alignmask support from ahash, this patch
makes the rockchip driver no longer use it.  This driver didn't actually
rely on it; it only writes to the result buffer in rk_hash_run(),
already using put_unaligned_le32().  And this driver only supports
unkeyed hash algorithms, so the key buffer need not be considered.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/rockchip/rk3288_crypto_ahash.c