]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
brcmfmac: sdio: Disable auto-tuning around commands expected to fail
authorDouglas Anderson <dianders@chromium.org>
Mon, 17 Jun 2019 17:56:51 +0000 (10:56 -0700)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 18 Jun 2019 11:30:29 +0000 (13:30 +0200)
commit2de0b42da263c97d330d276f5ccf7c4470e3324f
tree6bfac0730156c731cdc1f50ae7c614787a2bc3d5
parent0a55f4ab9678413a01e740c86e9367ba0c612b36
brcmfmac: sdio: Disable auto-tuning around commands expected to fail

There are certain cases, notably when transitioning between sleep and
active state, when Broadcom SDIO WiFi cards will produce errors on the
SDIO bus.  This is evident from the source code where you can see that
we try commands in a loop until we either get success or we've tried
too many times.  The comment in the code reinforces this by saying
"just one write attempt may fail"

Unfortunately these failures sometimes end up causing an "-EILSEQ"
back to the core which triggers a retuning of the SDIO card and that
blocks all traffic to the card until it's done.

Let's disable retuning around the commands we expect might fail.

Cc: stable@vger.kernel.org #v4.18+
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c