]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ARM: cns3xxx: Use actual size reads for PCIe
authorKoen Vandeputte <koen.vandeputte@ncentric.com>
Thu, 31 Jan 2019 21:00:11 +0000 (15:00 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 31 Jan 2019 21:07:16 +0000 (15:07 -0600)
commit432dd7064aa1c030a488745917cfa4ebc6c8c060
treef1d886fe820ed1ce333b8ddec6c05989a2357467
parent65dbb423cf28232fed1732b779249d6164c5999b
ARM: cns3xxx: Use actual size reads for PCIe

commit 802b7c06adc7 ("ARM: cns3xxx: Convert PCI to use generic config
accessors") reimplemented cns3xxx_pci_read_config() using
pci_generic_config_read32(), which preserved the property of only doing
32-bit reads.

It also replaced cns3xxx_pci_write_config() with pci_generic_config_write(),
so it changed writes from always being 32 bits to being the actual size,
which works just fine.

Given that:

- The documentation does not mention that only 32 bit access is allowed.
- Writes are already executed using the actual size
- Extensive testing shows that 8b, 16b and 32b reads work as intended

Allow read access of any size by replacing pci_generic_config_read32()
with the pci_generic_config_read() accessors.

Fixes: 802b7c06adc7 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Krzysztof Halasa <khalasa@piap.pl>
Acked-by: Arnd Bergmann <arnd@arndb.de>
CC: Krzysztof Halasa <khalasa@piap.pl>
CC: Olof Johansson <olof@lixom.net>
CC: Robin Leblon <robin.leblon@ncentric.com>
CC: Rob Herring <robh@kernel.org>
CC: Russell King <linux@armlinux.org.uk>
CC: Tim Harvey <tharvey@gateworks.com>
arch/arm/mach-cns3xxx/pcie.c